Bug 534168

(In reply to comment #0)
> Desktop:
Description:

...

SPEC: http://v3.sk/~lkundrak/SPECS/groovy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/groovy-1.6.5-2.src.rpm

Some prereview question:

* Why you have 'Reguires: groovy' on your package?
* should 'Requires: ivy' be 'Requires apache-ivy'?

(In reply to comment #3)
> Some prereview question:
> 
> * Why you have 'Reguires: groovy' on your package?

Probably a mistake.

> * should 'Requires: ivy' be 'Requires apache-ivy'?  

apache-ivy provides ivy. At least in jpackage the package is called ivy, therefore I find this good for cross-distro compatibility.

The project homepage of groovy offer groovy-1.6.6 as the current stable release.

It may be nice, if you can offer a new package based on this release.

(In reply to comment #5)
> The project homepage of groovy offer groovy-1.6.6 as the current stable
> release.
> 
> It may be nice, if you can offer a new package based on this release.  

Sure, here you are:

SPEC: http://v3.sk/~lkundrak/SPECS/groovy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/groovy-1.6.6-1.fc13.src.rpm

scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1845439
SPEC: http://v3.sk/~lkundrak/SPECS/groovy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/groovy-1.6.6-2.fc13.src.rpm

Good:
+ Basename of the SPEC file matches with package name
+ Name of the package fullfill naming guidelines
+ Consistently usage of rpm macros
+ URL tag shows to proper project homepage
+ License tag state ASL 2.0 as valid OSS license
+ License in the copyright notes on the top of the
  source files matches license stated by the license
  tag 
+ Could download upstream sources via spectool -g
+ Package sources matches with upstream
(md5sum: d50466fab035b9c4eaff87e8eadb119d)
+ Package contains a javadoc subpackage
+ Package has proper BuildRoot definition
+ BuildRoot will be cleaned at the beginning of %clean and %install
+ Local build works fine.
+ Rpmlint is silent on source package
+ Rpmlint is silent on binary package
+ Rpmlint is silent on javadoc subpackage
+ Scratch build on koji works fine
+ Local install and uninstall works fine
+ Start of application works without a crash
+ GUI menu works fine
+ Fies have proper permissions
+ Files stanza has no duplicated entries
+ All package files and dirs are own by the package
+ No file or dir may belong to another package
+ %doc stanza is small
+ Package has proper changelog

Bad:
- File LICENSE.txt doesn't contains a verbatin copy of
  the license text. Insteand you find a link to the
  license text provided by a website.
- Not all source files seems to have a copyright
  notice.
- It may be nice, if can the chose a shrter text
  for the GenericName tag in the desktop file

(In reply to comment #8)
> Bad:
> - File LICENSE.txt doesn't contains a verbatin copy of
>   the license text. Insteand you find a link to the
>   license text provided by a website.

Upstream was informed, this seems to be allowed per packaging guidelines though.

> - Not all source files seems to have a copyright
>   notice.

Sent a mail to upstream mailing list.

> - It may be nice, if can the chose a shrter text
>   for the GenericName tag in the desktop file  

Will do that for next package spin. Does this block review (or any of the above two?)

(In reply to comment #9)

> Will do that for next package spin. Does this block review (or any of the above
> two?)  

It may be nice, if we can do it in the package which we want to introduced into Fedora.

Jochen, I'm not sure what's the action point now and replying "may be nice" didn't really help me. Could you please be more specific at what blocks this review?

When I install groovy, I have the following menu text:

"Programming environment for the Groovy langua..."

This text is too large to display is at whole in the menu.

So it want to see, that you may find a shorter version of this text which should fit into the menu.

Best Regards:

Jochen Schmitt

SPEC: http://v3.sk/~lkundrak/SPECS/groovy.spec
SRPM: http://v3.sk/~lkundrak/SRPMS/groovy-1.6.7-1.fc12.src.rpm
scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1864098

Good:
+ Package contains recent release of the application
+ Packed tar ball matches with upstream
(md5sum: f63532d75560f101bf1f40b7a3760228)
+ Local build works fine
+ Local install/uninstall works fine
+ Desktop menu entry looks fine.
+ Mock build works fine


*** APPROVED ***

Thank you!

New Package CVS Request
=======================
Package Name: groovy
Short Description: Agile dynamic language for the Java Platform
Owners: lkundrak
Branches: F-11 F-12 EL-5

cvs done.

Imported and built.