Bug 534463 (RHQ-1257)
Summary: | RHQ_AGENT_DEBUG / RHQ_SERVER_DEBUG should allow for "false" value | ||
---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | John Mazzitelli <mazz> |
Component: | Launch Scripts | Assignee: | John Mazzitelli <mazz> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Corey Welton <cwelton> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | unspecified | Keywords: | Improvement |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | All | ||
URL: | http://jira.rhq-project.org/browse/RHQ-1257 | ||
Whiteboard: | |||
Fixed In Version: | 1.2 | Doc Type: | Enhancement |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | Type: | --- | |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
John Mazzitelli
2008-12-13 01:12:00 UTC
I had rhq-server.sh and rhq-agent-wrapper.sh reverse the meaning of the debug var. fixed in 2350. '1' will turn debug on, but '0' won't turn it off? I think I understand the purpose of using nearly any $value for RHQ_AGENT_DEBUG, but if we're going to implicitly allow '1', should '0' mean the opposite? Otherwise, these appear to work correctly.. QA Verified. Trying to keep it as backward compatible as possible. Before, setting this to "1" had no special meaning. That's because before, if the value was ANYTHING, debug was enabled. "1" was the same as "0" which was the same as "foo". As long as the variable was set, debug was enabled. Now, almost the same thing is still true. Setting the variable to "1" is the same as setting it to "true" is the same as setting it to "0" is the same as setting it to "foo" (this is backward compatible to the old script). The only difference now is if the value is "false", that explicitly does not turn on debug. So, the only way this breaks backward compatibility is if a user previously did this to enable debug mode: export RHQ_AGENT_DEBUG=false But I doubt anyone was doing that to actually turn on debug mode :) This bug was previously known as http://jira.rhq-project.org/browse/RHQ-1257 |