Bug 534592 (RHQ-1374)

Steps to reproduce

1) Go to the monitor tab for a resource
2) wait for your session to expire
3) click on a node in the nav tree on the left
4) when prompted enter your credentials again
5) get a 500 error...

HTTP Status 500 -

type Exception report

message

description The server encountered an internal error () that prevented it from fulfilling this request.

exception

javax.servlet.ServletException: viewId:/rhq/resource/monitor/tables.xhtml - View /rhq/resource/monitor/tables.xhtml could not be restored.
	javax.faces.webapp.FacesServlet.service(FacesServlet.java:270)
	org.ajax4jsf.webapp.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:177)
	org.ajax4jsf.webapp.BaseFilter.handleRequest(BaseFilter.java:267)
	org.ajax4jsf.webapp.BaseFilter.processUploadsAndHandleRequest(BaseFilter.java:380)
	org.ajax4jsf.webapp.BaseFilter.doFilter(BaseFilter.java:507)
	org.rhq.enterprise.gui.legacy.AuthenticationFilter.doFilter(AuthenticationFilter.java:129)
	org.rhq.enterprise.gui.common.upload.MultipartFilter.doFilter(MultipartFilter.java:63)
	org.rhq.helpers.rtfilter.filter.RtFilter.doFilter(RtFilter.java:116)
	org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)

root cause

javax.faces.application.ViewExpiredException: viewId:/rhq/resource/monitor/tables.xhtml - View /rhq/resource/monitor/tables.xhtml could not be restored.
	com.sun.faces.lifecycle.RestoreViewPhase.execute(RestoreViewPhase.java:186)
	com.sun.faces.lifecycle.Phase.doPhase(Phase.java:100)
	com.sun.faces.lifecycle.RestoreViewPhase.doPhase(RestoreViewPhase.java:104)
	com.sun.faces.lifecycle.LifecycleImpl.execute(LifecycleImpl.java:118)
	javax.faces.webapp.FacesServlet.service(FacesServlet.java:265)
	org.ajax4jsf.webapp.BaseXMLFilter.doXmlFilter(BaseXMLFilter.java:177)
	org.ajax4jsf.webapp.BaseFilter.handleRequest(BaseFilter.java:267)
	org.ajax4jsf.webapp.BaseFilter.processUploadsAndHandleRequest(BaseFilter.java:380)
	org.ajax4jsf.webapp.BaseFilter.doFilter(BaseFilter.java:507)
	org.rhq.enterprise.gui.legacy.AuthenticationFilter.doFilter(AuthenticationFilter.java:129)
	org.rhq.enterprise.gui.common.upload.MultipartFilter.doFilter(MultipartFilter.java:63)
	org.rhq.helpers.rtfilter.filter.RtFilter.doFilter(RtFilter.java:116)
	org.jboss.web.tomcat.filters.ReplyHeaderFilter.doFilter(ReplyHeaderFilter.java:96)

note The full stack trace of the root cause is available in the JBossWeb/2.0.0.GA logs.

i thought i fixed this a while back, but i guess the solution wasn't overarching enough.  i'll fix this properly this time.

rev2715 - fix the ViewExpiredException once and for all; 
you will now be redirected back to the URL you were on just before it was thrown; 

for testing, open the following file:

jbossas/server/default/deploy/rhq.ear/rhq-portal.war/WEB-INF/web.xml

change:

   <session-config>
      <session-timeout>30</session-timeout>
   </session-config>

to:

   <session-config>
      <session-timeout>1</session-timeout>
   </session-config>

this will expire the user's session after 1 minute, to facilitate quick testing.  go to some JSF page, say the operations tab for some resource.  select some operation to execute, but don't click the "execute" button yet.  wait one minute for the session to time out.  

now click the "execute" button.  you should be redirected to the login page first because you have no session anymore and the operations tab url is a "secure" url requiring a logged in.  once you log in, you should be on the SAME page you were before.  you'll need to click the button again, but this is A LOT better than getting a nasty stack trace.

This bug was previously known as http://jira.rhq-project.org/browse/RHQ-1374