Bug 534736 (RHQ-1503)

the algorithm in org.rhq.enterprise.gui.legacy.portlet.recentlyApproved.ViewAction is as follows:

* find recently approved platforms
* for each platform, if that platform is expanded (which is sticky in the user preferences), then get the recently approved servers beneath that platform for display

basically, if the platform is not expanded, it doesn't even get the recently approved servers for that platform because that information will be suppressed from the view anyway.  so, this is working as it always has.

what would be the proposal be if you wanted to see something different?

Actually the Recently added resources portlet on the dashboard is just empty -- which is different from how it has been in e.g. 2.1.

I don't really understand the explanation around "expanded".

Conclusion from yesterdays irc conversation was that this was never really working when you did not have a detailed look at an imported platform, which is just plain bad.

pilhuhn: I recall that we were thinking about some changes for ppl rapidly importing hundreds of boxes. But it being just empty and not showing anything at all is bad (and not how it worked in 2.1 or before)
[19:59] joseph: pilhuhn: i'm ready now if you are
[20:00] joseph: i just want to explain how it works today
[20:00] joseph: not have a discussion how it should work  ; )
[20:00] pilhuhn: sorry, can't hop on a call now
[20:01] pilhuhn: Well, if it can't display a single JBossAS being added anymore, then it is plain useless and we can remove it.
[20:01] joseph: k, well let me explain in txt a different way then...
[20:02] joseph: the recently added resources portlet is actually the recently added platforms porltet.  if you have a recently added portlet, then it will also show recently added servers.  however, by default, all platforms are collapsed, so their servers aren't shown / aren't queried.  if you expand one server, that becomes a "sticky" preference and is persisted.  if you visit later, and if your platform is still considered recently added, then it will still
[20:02] joseph: i looked at svn history for this, and this is apparently how it's been since the import into RHQ svn
[20:03] pilhuhn: hmm. So you say that because my platform is "too old", frehsly imported servers on it don't show up -- except if I had looked at the platform in more detail?
[20:04] mazz: that's correct. I seem to remember this - did I write that code? Maybe that was part of my fixing the dashboard portlets those many moons ago
[20:04] joseph: pilhuhn: correct
pilhuhn: This sucks and makes the portlet imho useless
[20:05] pilhuhn: (or close to)
[20:05] mazz: its not useless
[20:05] mazz: you can see new platforms
[20:05] mazz: rename the portlet "Recently Added Platforms"
[20:05] mazz: and its working just fine. :-D
[20:05] pilhuhn: *sigh*
[20:06] joseph: pilhuhn: i did say to comment in the jira how you'd like it to work
[20:06] mazz: perhaps we just get rid of the ability to collapse
[20:06] mazz: just always show the expanded platfoms
[20:06] mazz: that way, all the queries work

This bug was previously known as http://jira.rhq-project.org/browse/RHQ-1503

Temporarily adding the keyword "SubBug" so we can be sure we have accounted for all the bugs.

keyword:
new = Tracking + FutureFeature + SubBug

making sure we're not missing any bugs in rhq_triage

This seems fine in the new Recently Added portlet.

uninventoried EAP, inventoried it, reviewed recently added resources portlet.  verified.

Bulk closing of issues that were VERIFIED, had no target release and where the status changed more than a year ago.