Red Hat Bugzilla – Full Text Bug Listing
|Summary:||center column data in resource hub|
|Product:||[Other] RHQ Project||Reporter:||John Mazzitelli <mazz>|
|Component:||Core UI||Assignee:||John Mazzitelli <mazz>|
|Status:||CLOSED NEXTRELEASE||QA Contact:||Jeff Weiss <jweiss>|
|Fixed In Version:||1.2||Doc Type:||Enhancement|
|Doc Text:||Story Points:||---|
|oVirt Team:||---||RHEL 7.3 requirements from Atomic Host:|
Description John Mazzitelli 2009-04-02 19:12:00 EDT
look at attachment - I think it would look better if the right most column data (the counts/icons) were not right-aligned - they should be centered in the column cell.
Comment 1 John Mazzitelli 2009-04-11 02:25:54 EDT
screenshot-2 shows the problem more clear. The "Children" and "Descendents" headers are left-aligned but the icons are right aligned. They look really off and you can't really tell if the first "0 (?)" is under Children or Descendents - in fact, it looks MORE like it belongs under Descendents than Children (which is where it really belongs).
Comment 2 John Mazzitelli 2009-04-11 02:29:33 EDT
The problem is in GroupHub.jsp: <display:column width="10%" property="explicitFormatted" title="resource.common.monitor.visibility.ChildAvailabilityTH" headerStyleClass="ListHeaderCheckbox" valign="middle" sortAttr="explicitAvail"/> <display:column width="10%" property="implicitFormatted" title="resource.common.monitor.visibility.DescendentAvailabilityTH" headerStyleClass="ListHeaderCheckbox" valign="middle" sortAttr="implicitAvail"/> That headerStyleClass is completely ignored. I tried created my own class and using it, I also tried adding a "style: text-align: right" but <display:column> doesn't accept style attribute. Using FF DOM inspector, it tells me the header cells are of class "tableRowInactive". I can't see how I can change this for just these two display:column elements. Somehow, we need those cells to be "text-align: right;" (or center, but I think right will look best). But I can't find a way to do it.
Comment 3 John Mazzitelli 2009-04-11 03:10:25 EDT
see the attached screenshot for the new way this is rendered. I basically changed the alignment of the rows to be left aligned, not right aligned. These put the images more directly under the header names. For those groups that only have a single image (all UP, all DOWN or grey) the images are directly under the header string, which is nice.
Comment 4 Jeff Weiss 2009-04-14 14:26:26 EDT
Fixed, rev3727. The groups tabs look like the final screenshot attached. I think the alignment could still use some improvement, but it's good enough for this release.