Bug 535199 (RHQ-1920)
Summary: | center column data in resource hub | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | John Mazzitelli <mazz> | ||||||||
Component: | Core UI | Assignee: | John Mazzitelli <mazz> | ||||||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Jeff Weiss <jweiss> | ||||||||
Severity: | medium | Docs Contact: | |||||||||
Priority: | low | ||||||||||
Version: | unspecified | CC: | dajohnso | ||||||||
Target Milestone: | --- | Keywords: | Improvement | ||||||||
Target Release: | --- | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
URL: | http://jira.rhq-project.org/browse/RHQ-1920 | ||||||||||
Whiteboard: | |||||||||||
Fixed In Version: | 1.2 | Doc Type: | Enhancement | ||||||||
Doc Text: | Story Points: | --- | |||||||||
Clone Of: | Environment: | ||||||||||
Last Closed: | Type: | --- | |||||||||
Regression: | --- | Mount Type: | --- | ||||||||
Documentation: | --- | CRM: | |||||||||
Verified Versions: | Category: | --- | |||||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||||
Embargoed: | |||||||||||
Attachments: |
|
Description
John Mazzitelli
2009-04-02 23:12:00 UTC
screenshot-2 shows the problem more clear. The "Children" and "Descendents" headers are left-aligned but the icons are right aligned. They look really off and you can't really tell if the first "0 (?)" is under Children or Descendents - in fact, it looks MORE like it belongs under Descendents than Children (which is where it really belongs). The problem is in GroupHub.jsp: <display:column width="10%" property="explicitFormatted" title="resource.common.monitor.visibility.ChildAvailabilityTH" headerStyleClass="ListHeaderCheckbox" valign="middle" sortAttr="explicitAvail"/> <display:column width="10%" property="implicitFormatted" title="resource.common.monitor.visibility.DescendentAvailabilityTH" headerStyleClass="ListHeaderCheckbox" valign="middle" sortAttr="implicitAvail"/> That headerStyleClass is completely ignored. I tried created my own class and using it, I also tried adding a "style: text-align: right" but <display:column> doesn't accept style attribute. Using FF DOM inspector, it tells me the header cells are of class "tableRowInactive". I can't see how I can change this for just these two display:column elements. Somehow, we need those cells to be "text-align: right;" (or center, but I think right will look best). But I can't find a way to do it. see the attached screenshot for the new way this is rendered. I basically changed the alignment of the rows to be left aligned, not right aligned. These put the images more directly under the header names. For those groups that only have a single image (all UP, all DOWN or grey) the images are directly under the header string, which is nice. Fixed, rev3727. The groups tabs look like the final screenshot attached. I think the alignment could still use some improvement, but it's good enough for this release. This bug was previously known as http://jira.rhq-project.org/browse/RHQ-1920 Imported an attachment (id=368696) Imported an attachment (id=368697) Imported an attachment (id=368698) |