Bug 535272 (RHQ-1986)
Summary: | group of similar resources isn't being rendered correctly | ||||||
---|---|---|---|---|---|---|---|
Product: | [Other] RHQ Project | Reporter: | John Mazzitelli <mazz> | ||||
Component: | Core UI | Assignee: | John Mazzitelli <mazz> | ||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | unspecified | CC: | mfoley | ||||
Target Milestone: | --- | Keywords: | SubBug | ||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
URL: | http://jira.rhq-project.org/browse/RHQ-1986 | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2013-09-02 07:22:17 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 565628, 585306, 662118 | ||||||
Attachments: |
|
Description
John Mazzitelli
2009-04-17 05:53:00 UTC
for the record, resource type ID of 501077 is: id name category creation_data_type create_delete_policy singleton supports_manual_add description plugin ctime mtime subcategory_id plugin_config_def_id res_config_def_id 501077 Script SERVICE CONFIGURATION NEITHER false true provides the ability to execute a script that performs some task related to its parent JBossAS server JBossAS 1239944619687 1239944619750 500050 501619 (null) This bug was previously known as http://jira.rhq-project.org/browse/RHQ-1986 Imported an attachment (id=368720) Temporarily adding the keyword "SubBug" so we can be sure we have accounted for all the bugs. keyword: new = Tracking + FutureFeature + SubBug making sure we're not missing any bugs in rhq_triage i need to check to see if this is still happening in gwt the problem is that the resource keys contain backslashes (Windows strikes again!) The resource keys for the scripts are the full paths such as: C:\jboss-as\bin\run.bat But the query we build up doesn't escape the path, which we include hardcoded in the query - here's is an actual example of the query we execute, notice the resource key enclosed in single quotes: SELECT r1 FROM Resource r1 WHERE r1.resourceKey = 'C:\jboss-as\bin\run.bat' AND r1.resourceType = 10147 AND r1.parentResource IN ( SELECT rgir FROM ResourceGroup rg JOIN rg.implicitResources rgir WHERE rg = 10121) When I replace that key string such that its backslashes are escaped (that is "\\" instead of "\"), the query returns the proper results. Unsure if Oracle requires the escape characters, but we should probably change these queries to use :param parameters so we don't have to worry about escaping characters. commit 45e8f87a3ec5d9ab5e66d21d082c6b7ff88d4ea4 we now use :param notation to pass in the resource key parameters, rather than hardcoding them. this works around any need we would have had to escape characters in the hardcoded resource keys tested RHQ Master ...using Oracle repository. Confirmed by using SQL to verify that RHQ_RESOURCE table contains data with slashes "/" ... and using DEBUG level logging that no errors in SQL execution. I have been performing numerous qualifications since the bug fix 3/11 and this is fine. Bulk closing of issues that were VERIFIED, had no target release and where the status changed more than a year ago. |