Bug 535618 (RHQ-2295)

Summary:	Uninventory, then manually add of the same server resource leaves it in inconsistent state
Product:	[Other] RHQ Project	Reporter:	Jeff Weiss <jweiss>
Component:	Inventory	Assignee:	Charles Crouch <ccrouch>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jeff Weiss <jweiss>
Severity:	medium	Docs Contact:
Priority:	high
Version:	1.3pre	CC:	cwelton, dajohnso, hbrock, jshaughn
Target Milestone:	---	Flags:	cwelton: needinfo? (jmarques) cwelton: needinfo? (ccrouch)
Target Release:	---
Hardware:	All
OS:	All
URL:	http://jira.rhq-project.org/browse/RHQ-2295
Whiteboard:
Fixed In Version:	1.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:	rev4650
Last Closed:	2014-05-09 11:32:44 EDT	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---

Description Jeff Weiss 2009-08-05 15:07:00 EDT

How to repeat:

Find a server resource that you can manually add to a platform, that your server has already discovered, like apache, postgres, etc.  Write down the conn props for that resource, then uninventory it.  Now try to manually add it back, with the conn props you recorded earlier.  Be sure to manually add right away (when I did it, it was within 1 or 2 minutes of uninventorying).

Message in yellow is "A Apache HTTP Server with the specified connection properties was already in inventory"

You are left on an inventory page for the resource, but the resource isn't shown anywhere else (resource browser, left nav,etc).

Comment 1 Greg Hinkle 2009-08-06 12:12:09 EDT

Joe to make sure resources do get properly deleted.

Comment 2 Corey Welton 2009-08-26 14:55:27 EDT

Pushed to 1.4

Comment 3 Red Hat Bugzilla 2009-11-10 16:01:40 EST

This bug was previously known as http://jira.rhq-project.org/browse/RHQ-2295

Comment 4 Charles Crouch 2010-05-17 17:38:44 EDT

I'm setting this to a higher priority for investigation in the future, since I think it indicates we're not checking the resource status properly, which would be bad. But this is not a common execution path, so will not be targeted for 2.4

Comment 5 Joseph Marques 2010-05-17 18:03:18 EDT

Hmm...this is a long-standing bug.  My apologies for not seeing it originally Jeff / Greg.

-----

Jeff...

The issue here is that uninventorying a server will communicate with the agent responsible for managing that resource.  It will remove that resource from the agent-side inventory...which then (I believe) triggers another auto-discovery scan...which re-discovers and re-reports the resource.

In this case, the error message (depending on timing) might be completely accurate.  If you go back to the auto-discovery portlet after seeing the error message, you'll notice that the resource IS in fact there (in this case, it's in the NEW state and needs to be re-imported).

Greg...

I don't believe this is an issue with async uninventory (first available in the RHQ 1.3.0 release, shortly before this bug was filed).  Part of the in-band work for uninventory is to "destroy" the just-uninventoried resources by:

1) Marking the InventoryStatus as UNINVENTORIED (async job processes these)
2) Setting the agent reference to NULL (simulate agent-side deletion)
3) Setting the parent resource to NULL (async delete can occur in any order)
4) Setting the resourceKey to 'deleted' (prevents dup resourceKey during rediscovery)

-----

So I think next steps are to kick this back to QA, re-run the reproduction steps, and determine whether the above analysis (the resource is automatically rediscovered and can be found in the AD portlet) is correct.  If it is, then the very least we can do is adjust the error message to be more accurate, and point (or redirect) the user to the correct place depending on which state (InventoryState) the resource is in.

Comment 6 Corey Welton 2010-08-30 13:39:04 EDT

Joseph/Charles:  fix or doco this?