Bug 536017 (RHQ-411)

Summary:

"Required" error message on group definition change is unreadable

Product:

[Other] RHQ Project

Reporter:

Jason Dobies <__jdobies>

Component:

Inventory

Assignee:

Joseph Marques <jmarques>

Status:

CLOSED NEXTRELEASE

QA Contact:

Jeff Weiss <jweiss>

Severity:

medium

Docs Contact:

Priority:

low

Version:

unspecified

CC:

dajohnso

Target Milestone:

---

Keywords:

SubBug

Target Release:

---

Hardware:

All

OS:

All

URL:

http://jira.rhq-project.org/browse/RHQ-411

Whiteboard:

Fixed In Version:

1.1

Doc Type:

Bug Fix

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Bug Depends On:

Bug Blocks:

536002

Attachments:

Description	Flags
error.png	none

Description Jason Dobies 2008-05-01 20:17:00 UTC

To reproduce:
- Create a resource group definition
- Click Edit
- Delete the definition name
- Click OK

The error message telling the user that the name is required is squished on the side of the screen. See attached screen shot.

Comment 1 Heiko W. Rupp 2008-06-11 07:42:39 UTC

Actually the "name" field should be read-only at that point, as it was already set before.

Comment 2 Heiko W. Rupp 2008-06-11 07:58:50 UTC

Issue is most likely provoked by 3 columns having :

.general-props-cell {
   width: 50%;


But even when this is fixed, an error message of "For property "j_id32:name", a value is required" is not acceptable.

Comment 3 Joseph Marques 2008-07-02 10:47:41 UTC

low-hanging fruit, should take me < 30 mins to fix, so setting for 1.1

Comment 4 Joseph Marques 2008-08-11 19:06:15 UTC

rev1219 - instead of using field level validation, let the backing UIBean handle the validation by injecting global-level errors into the faces context; 
update the GroupDefinitionManager to perform all non-null and max-length validating rules for new and edited group definitions, throwing exceptions to the UI layer as appropriate; 
update the facelets template for group definitions (/rhq/definition/layout/main.xhtml) to display these global errors on all pages that extend it;

Comment 5 Jeff Weiss 2008-08-20 19:59:50 UTC

rev1250, error message is now displayed correctly.

Comment 6 Red Hat Bugzilla 2009-11-10 21:08:45 UTC

This bug was previously known as http://jira.rhq-project.org/browse/RHQ-411
Imported an attachment (id=368824)
This bug is duplicated by RHQ-801