Bug 536445 (RHQ-793)
| Summary: | allow discovery / management of apache instances containing whitespace in the executable path | ||
|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Joseph Marques <jmarques> |
| Component: | Plugins | Assignee: | Heiko W. Rupp <hrupp> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Corey Welton <cwelton> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 1.1pre | Keywords: | Improvement |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://jira.rhq-project.org/browse/RHQ-793 | ||
| Whiteboard: | |||
| Fixed In Version: | 1.2 | Doc Type: | Enhancement |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Joseph Marques
2008-09-07 00:03:00 UTC
Underlying issue is this check in the constructor of ProcessExecution:
StringTokenizer splitter = new StringTokenizer(executable);
if (splitter.countTokens() > 1) {
throw new IllegalArgumentException("executable cannot contain whitespace. Executable: [" + executable + "]");
}
It filters all path with whitespaces -- even if they had been escaped as in "/tmp/t\ est/echo".
Note that doing the following
ProcessExecution pe = new ProcessExecution("dummy");
pe.setExecutable("/tmp/t\ est/echo");
will not check for whitespaces and will happily execute the echo command
I have to believe we can take that tokenizer check out. I can't see how that could ever be a good thing - since Windows loves spaces in full paths to executables. Whatever this was meant to fix, needs to be fixed in another way - this check has to be removed. Check for spaces has been eliminated. QA Verified, I have set the executable location to "/tmp/foo bar/httpd" (a symlink to the original location) and submitted. The system appears to have no problems finding the httpd server. This bug was previously known as http://jira.rhq-project.org/browse/RHQ-793 |