Bug 536496 (RHQ-840)
| Summary: | Attribute 'default' for <c:option> not honored | ||
|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Heiko W. Rupp <hrupp> |
| Component: | Plugin Container | Assignee: | Charles Crouch <ccrouch> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 1.0 | CC: | cwelton, hbrock, mfoley |
| Target Milestone: | --- | Keywords: | SubBug |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| URL: | http://jira.rhq-project.org/browse/RHQ-840 | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-09-03 16:57:22 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 585306 | ||
Raising priority, as this confuses developers. The default seems to be pulled out of the descriptor, but never ever used. So just removing it from <option/> could be the simplest option. setting "fixed version" to 1.2 to consider getting this in for next release. this should be an extremely easy fix and since the attrib was never used in the first place, there is no backward compatiblity issues to worry about. ACtually I see that it is referenced in ConfigurationMetadataManager.updatePropertyDefinition(), but not mixed and matched with the default from the simple-property This bug was previously known as http://jira.rhq-project.org/browse/RHQ-840 Temporarily adding the keyword "SubBug" so we can be sure we have accounted for all the bugs. keyword: new = Tracking + FutureFeature + SubBug making sure we're not missing any bugs in rhq_triage commit 1d814e5, pushed to master, completely removes the is_default option from the code base. This entailed: 1) remove field from PropEnum entity 2) remove column from DB in dbsetup/dbupgrade scripts 3) remove attribute from rhq-configuration.xsd 4) remove usage of attribute from any rhq-plugin.xml's that use it (there were a lot, so it's possible I missed one or two) internal refactoring. searched codebase for any remnants of is_default Bulk closing of old issues that are in VERIFIED state. |
When setting up a property with options like the following, then the attribute 'default' is ignored and both values are not checked in the GUI. <c:simple-property name="foo"> <c:property-options> <c:option value="POJO Cache" default="false"/> <c:option value="Tree Cache" default="true"/> </c:property-options> </c:simple-property> A default is only set when the c:simple-property gets a default attribute too: <c:simple-property name="foo" default="Tree Cache" > We should either fix this that the default property from the options are taken or (as this might prevent double usage), remove the default attribute on c:option and only use the default from c:simple-property.