Bug 536496 (RHQ-840)

Summary: Attribute 'default' for <c:option> not honored
Product: [Other] RHQ Project Reporter: Heiko W. Rupp <hrupp>
Component: Plugin ContainerAssignee: Charles Crouch <ccrouch>
Severity: medium Docs Contact:
Priority: medium    
Version: 1.0CC: cwelton, hbrock, mfoley
Target Milestone: ---Keywords: SubBug
Target Release: ---   
Hardware: All   
OS: All   
URL: http://jira.rhq-project.org/browse/RHQ-840
See Also: https://bugzilla.redhat.com/show_bug.cgi?id=738029
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-09-03 12:57:22 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 585306    

Description Heiko W. Rupp 2008-09-16 07:05:00 EDT
When setting up a property with options like the following, then the attribute 'default' is ignored and both values are not checked in the GUI.

<c:simple-property name="foo">
               <c:option value="POJO Cache" default="false"/>
               <c:option value="Tree Cache" default="true"/>

A default is only set when the c:simple-property gets a default attribute too:

<c:simple-property name="foo" default="Tree Cache" >

We should either fix this that the default property from the options are taken or (as this might prevent double usage),
remove the default attribute on c:option and only use the default from c:simple-property.
Comment 1 Heiko W. Rupp 2008-11-28 15:41:00 EST
Raising priority, as this confuses developers.
Comment 2 Heiko W. Rupp 2009-01-29 09:26:28 EST
The default seems to be pulled out of the descriptor, but never ever used. 
So just removing it from <option/> could be the simplest option.
Comment 3 John Mazzitelli 2009-01-29 09:35:33 EST
setting "fixed version" to 1.2  to consider getting this in for next release. this should be an extremely easy fix and since the attrib was never used in the first place, there is no backward compatiblity issues to worry about.
Comment 4 Heiko W. Rupp 2009-01-29 09:42:05 EST
ACtually I see that it is referenced in ConfigurationMetadataManager.updatePropertyDefinition(), but not mixed and matched with the default from the simple-property 
Comment 5 Red Hat Bugzilla 2009-11-10 16:18:00 EST
This bug was previously known as http://jira.rhq-project.org/browse/RHQ-840
Comment 6 wes hayutin 2010-02-16 11:57:04 EST
Temporarily adding the keyword "SubBug" so we can be sure we have accounted for all the bugs.

new = Tracking + FutureFeature + SubBug
Comment 7 wes hayutin 2010-02-16 12:02:09 EST
making sure we're not missing any bugs in rhq_triage
Comment 8 Ian Springer 2010-10-07 12:57:35 EDT
commit 1d814e5, pushed to master, completely removes the is_default option from the code base. This entailed:

1) remove field from PropEnum entity
2) remove column from DB in dbsetup/dbupgrade scripts
3) remove attribute from rhq-configuration.xsd
4) remove usage of attribute from any rhq-plugin.xml's that use it (there were a lot, so it's possible I missed one or two)
Comment 9 Mike Foley 2011-07-08 14:59:15 EDT
internal refactoring.  searched codebase for any remnants of is_default
Comment 11 Heiko W. Rupp 2013-09-03 12:57:22 EDT
Bulk closing of old issues that are in VERIFIED state.