Bug 536948
| Summary: | RFC: Emit python3-coverage subpackage as part of the python-coverage build | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dave Malcolm <dmalcolm> |
| Component: | python-coverage | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | 12 | CC: | lmacken, tcallawa |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-05 19:35:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 531895 | ||
| Bug Blocks: | 530636 | ||
| Attachments: | |||
|
Description
Dave Malcolm
2009-11-11 21:22:20 UTC
Created attachment 369108 [details]
Patch to python-coverage.spec to add a python3- subpackage (no changelog entry yet)
Created attachment 369109 [details]
patch1 from specfile patch, described there. Not yet sent upstream.
With these, I was able to do a local rebuild of the srpm; I tested the /usr/bin/coverage3 (the python3 variant) with a simple .py file and it appears to work as well as /usr/bin/coverage (the python2 variant) I've reported the patching I had to do with upstream here: http://bitbucket.org/ned/coveragepy/issue/29/python-3-version-of-setuppy-fails-in-tarball-due-to-missing-scripts-subdir-but-appears-not-to-be This bug appears to have been reported against 'rawhide' during the Fedora 12 development cycle. Changing version to '12'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Created attachment 388353 [details] Updated specfile patch to add python3- subpackage Attaching an updated version of the specfile patch, reflecting the latest recommendations on https://fedoraproject.org/wiki/PackagingDrafts/Python3 (Still blocked on python3-setuptools, though) Upstream does intend for the tarball to support both Python 2 and Python 3 c.f: "The latest version is 3.2, released 5 December 2009. It is supported on Python 2.3 through 3.1." from http://nedbatchelder.com/code/coverage/ Tested with a local build; $ head -n1 $(which python3-coverage) #!/usr/bin/python3 so it is indeed invoking python3 $ python3-coverage help prints the expected list of commands $ python3-coverage run testcoverage.py on this trivial code: if True: print('got here') if False: print("shouldn't get here") emitted a ".coverage" file, and $ python3-coverage html -d fubar generated a (correct) HTML report. Verifying the python2 case: $ head -n1 $(which coverage) #!/usr/bin/python so that executable is still using python2 $ coverage help etc; I also successfully manage to execute the "run" and "html" commands using the python2 version of the code. python-setuptools has now been built in dist-f13 with the python3-setuptools subpackage, so I believe we'll be good to go with this as soon as that package reaches the dist-f13-build build tag. Luke: I'm hoping to get this done by F13 Feature Freeze, and I'm guessing Tom isn't going to be responsive to bz mail; is it OK to apply the patch and rebuild with the new python3 support? I've requested commit access here: https://admin.fedoraproject.org/pkgdb/packages/name/python-coverage Spot gave me CVS access; I've gone ahead and implemented this. I noticed a few places in my patch where I wasn't fully following the new Python 3 packaging guidelines, and fixed them. Likewise, I needed to add a runtime dep on python3-setuptools (aka bug 556290); I also needed to add a BuildRequires on 2to3. CVS diff here: http://cvs.fedoraproject.org/viewvc/rpms/python-coverage/devel/python-coverage.spec?r1=1.7&r2=1.8 Successfully built into dist-f13 as python-coverage-3.2-3.fc13: http://koji.fedoraproject.org/koji/taskinfo?taskID=1965558 http://koji.fedoraproject.org/koji/buildinfo?buildID=154636 |