| Summary: | Review Request: cglib - Code generation library for Java | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lubomir Rintel <lkundrak> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, jochen, mefoster, notting |
| Target Milestone: | --- | Flags: | jochen:
fedora-review+
tibbs: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | F13FeatureIDEA | ||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-17 12:31:11 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Lubomir Rintel
2009-11-12 11:23:57 UTC
*** Bug 469894 has been marked as a duplicate of this bug. *** The package here is from bug #537066, I was satisfied with it (it would pass my review as-is if I were reviewing it), so I did not make any changes. (In reply to comment #2) > The package here is from bug #537066 bug #469894 Good: + Package fullfill naming guidelines + Consistently rpm macro usage + URL shows on proper homepage + License tag exclaim ASL 2.0 as valid OSS license + Package contains verbatin copy of the license text + Copyright notes in the sources matches with license tag + Could download upstream sources via spectool -g + Package tar ball matches with upstream (md5sum: b1e6ebfb76ec7071b6a3f5f9d7df2e57) + Patch seams to be reliable + Package will build as noarch + Package has proper BuildRoot definition + Local build works fine + Rpmlint is silent for source package + Rpmlint is silent for binary package + Rpmlint is silent for javadoc package + Koji build works fine + Package as javadoc subpackage for Java API documentation + %doc stanza is small + Files stanza has proper file permissions definitions + All java class are put in a singel jar file + Package contains versioned and unversioned jar file + Files stanza has no duplicated entries + all package files are owned by the package + Package has no files which may belongs to other packages + Package has proper change log *** APPROVED *** Danke schon Jochen! New Package CVS Request ======================= Package Name: cglib Short Description: Code generation library for Java Owners: lkundrak mef Branches: F-12 EL-5 CVS done. Thanks for review and CVS. Imported and built. |