Bug 538149

Summary:	create new content provider with invalid values completes without any error if click save a second time
Product:	[Other] RHQ Project	Reporter:	Preethi Thomas <pthomas>
Component:	Configuration	Assignee:	RHQ Project Maintainer <rhq-maint>
Status:	CLOSED WORKSFORME	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	unspecified	CC:	cwelton, jason.dobies, jsefler
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-03-29 17:34:30 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	538145

Description Preethi Thomas 2009-11-17 18:39:53 UTC

Description of problem:

Create new content provider with invalid values completes without any error if click save a second time
Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.Administration->Content->Content Provider->Create New-> RHN Hosted Source
2.Enter Values for all the required fields
3.Enter invalid location (htp:)
5. Click save
6. See the error.
7. Click on save again
Actual results:

The content provider is created without any errors

Expected results:
Content provider should fail to create.


Additional info:

Comment 1 Jay Dobies 2009-12-04 20:12:33 UTC

I think it's related, but the new information entered is never sent to the content provider. A slight variation on the above reproduction:

1.Administration->Content->Content Provider->Create New-> RHN Hosted Source
2.Enter Values for all the required fields
3.Enter invalid location (htp:)
5. Click save
6. See the error.
** 7. Enter correct data ***
8. Click on save again

Here I expected the provider to be created without any errors, which it did. However, when I went to use the provider it continued to use the bad property values.

Comment 2 Jay Dobies 2009-12-04 20:14:27 UTC

*** Bug 536883 has been marked as a duplicate of this bug. ***

Comment 3 Jay Dobies 2009-12-07 20:56:15 UTC

commit	2d66e832766c3ec234f08bb7105d5b6dad57fe9e
tree	2b305d3dbd08303b4d2f630109bb10bcb180b5b5

ContentProviderManager.java

If the provider does not start correctly, we need to make sure it's removed from the cache. Otherwise, future calls to start (which occur when the user attempts to correct the failed start errors) will simply return assuming it's started.

Comment 4 Corey Welton 2010-03-29 17:32:27 UTC

Mass-move to ON_QA

Comment 5 Corey Welton 2010-03-29 17:34:30 UTC

QA Closing - essentially untestable now.