Bug 538335

Summary: Review Request: dia-CMOS - Dia CMOS Shapes
Product: [Fedora] Fedora Reporter: Chitlesh GOORAH <chitlesh>
Component: Package ReviewAssignee: Parag AN(पराग) <panemade>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, panemade
Target Milestone: ---Flags: panemade: fedora-review+
dennis: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 0.1-1.el5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-11-24 07:33:46 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Chitlesh GOORAH 2009-11-18 09:57:42 UTC
Spec URL: http://chitlesh.fedorapeople.org/RPMS/dia-CMOS.spec
SRPM URL: http://chitlesh.fedorapeople.org/RPMS/dia-CMOS-0.1-1.fc12.src.rpm
Description:
The following shapes are included in the package:
 * NMOS Transistor
 * PMOS Transistor
 * Ground
 * Vdd

Comment 1 Parag AN(पराग) 2009-11-20 05:53:52 UTC
Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1818824
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url(sha1sum)
5b27b98a32316db76e0bda67fb697b8ab3f7d6e1  cmos.zip
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Not a GUI application

Suggestions:
License should be GPLv2+

APPROVED.

Comment 2 Chitlesh GOORAH 2009-11-20 12:33:59 UTC
New Package CVS Request
=======================
Package Name: dia-CMOS
Short Description: Dia CMOS Shapes
Owners: chitlesh
Branches: F-11 F-12 EL-5

Comment 3 Dennis Gilmore 2009-11-20 22:33:03 UTC
CVS Done

Comment 4 Fedora Update System 2009-11-20 23:44:14 UTC
dia-CMOS-0.1-1.el5 has been submitted as an update for Fedora EPEL 5.
http://admin.fedoraproject.org/updates/dia-CMOS-0.1-1.el5

Comment 5 Fedora Update System 2009-11-20 23:44:19 UTC
dia-CMOS-0.1-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/dia-CMOS-0.1-1.fc12

Comment 6 Fedora Update System 2009-11-20 23:44:24 UTC
dia-CMOS-0.1-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/dia-CMOS-0.1-1.fc11

Comment 7 Fedora Update System 2009-11-23 16:56:13 UTC
dia-CMOS-0.1-1.el5 has been pushed to the Fedora EPEL 5 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update dia-CMOS'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0891

Comment 8 Fedora Update System 2009-11-24 07:33:41 UTC
dia-CMOS-0.1-1.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2009-11-24 07:52:18 UTC
dia-CMOS-0.1-1.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2009-12-10 04:01:29 UTC
dia-CMOS-0.1-1.el5 has been pushed to the Fedora EPEL 5 stable repository.  If problems still persist, please make note of it in this bug report.