Bug 538361
| Summary: | Review Request: perl-CPAN-Checksums - Write a CHECKSUMS file for a directory as on CPAN | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-20 07:40:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 538360 | ||
|
Description
Marcela Mašláňová
2009-11-18 11:37:46 UTC
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1813940 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) 2e1aa5110006511eb293d581b5e987eca9b4ca4b CPAN-Checksums-2.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=4, Tests=22, 2 wallclock secs ( 0.03 usr 0.01 sys + 0.33 cusr 0.04 csys = 0.41 CPU) + Package perl-CPAN-Checksums-2.04-1.fc13.noarch => Provides: perl(CPAN::Checksums) = 2.04 Requires: perl(Compress::Bzip2) perl(Compress::Zlib) perl(Data::Compare) perl(Data::Dumper) perl(Digest::MD5) perl(Digest::SHA) perl(DirHandle) perl(Exporter) perl(File::Spec) perl(File::Temp) perl(IO::File) perl(strict) perl(vars) + Not a GUI application Suggestions: 1) please remove requires from spec Requires: perl(Compress::Bzip2) Requires: perl(Compress::Zlib) Requires: perl(Data::Compare) Requires: perl(Digest::SHA) APPROVED. Useless requirements removed, thank you for your review. New Package CVS Request ======================= Package Name: perl-CPAN-Checksums Short Description: Write a CHECKSUMS file for a directory as on CPAN Owners: mmaslano Branches: devel InitialCC: perl-sig CVS done. |