Bug 538458
| Summary: | Review Request: perl-Format-Human-Bytes - Format a bytecount and make it human readable | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-11-25 08:30:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Marcela Mašláňová
2009-11-18 16:16:29 UTC
I assume you mean http://mmaslano.fedorapeople.org/review/perl-Format-Human-Bytes.spec Oh my, yes(In reply to comment #1) > I assume you mean > http://mmaslano.fedorapeople.org/review/perl-Format-Human-Bytes.spec Oh my, yes I meant this ^ I'm sorry, too many packages at once... no problem.I will take this for review. Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1818830 + rpmlint is silent for SRPM and for RPM. + source files match upstream url (sha1sum) 03cd933d75076170ffb81f62ebe791dee983ed98 Format-Human-Bytes-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=216, 0 wallclock secs ( 0.04 usr 0.00 sys + 0.10 cusr 0.02 csys = 0.16 CPU) + Package perl-Format-Human-Bytes-0.04-1.fc13.noarch => Provides: perl(Format::Human::Bytes) = 0.04 Requires: perl(strict) perl(warnings) + Not a GUI application APPROVED. New Package CVS Request ======================= Package Name: perl-Format-Human-Bytes Short Description: Format a bytecount and make it human readable Owners: mmaslano Branches: devel InitialCC: perl-sig CVS Done |