Bug 539642

Summary: use native pci_get_bus_and_slot function
Product: Red Hat Enterprise Linux 5 Reporter: Eduardo Habkost <ehabkost>
Component: kvmAssignee: Eduardo Habkost <ehabkost>
Status: CLOSED NEXTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: low Docs Contact:
Priority: medium    
Version: 5.5CC: mburns, mjenner, tburke, virt-maint, ykaul
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: kvm-83-203.el5 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 539589 Environment:
Last Closed: 2010-10-28 12:55:21 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 539589    
Bug Blocks: 580948    

Description Eduardo Habkost 2009-11-20 18:56:37 UTC
Related to Bug #539589, once we solve the compat code conflict, we may consider using the recently-introduced native pci_get_bus_and_slot() function.


+++ This bug was initially created as a clone of Bug #539589 +++

Description of problem:

KVM can't build against newer RHEL-5.5 test kernels:

make[2]: Entering directory `/usr/src/kernels/2.6.18-174.el5-x86_64'
  LD      /var/lib/builder/rhevh/source-root/kvm/kernel/x86/built-in.o
  CC [M]  /var/lib/builder/rhevh/source-root/kvm/kernel/x86/svm.o
  CC [M]  /var/lib/builder/rhevh/source-root/kvm/kernel/x86/../external-module-compat.o
In file included from /var/lib/builder/rhevh/source-root/kvm/kernel/x86/../external-module-compat.c:312:
include/linux/pci.h:541: error: static declaration of ‘pci_get_bus_and_slot’ follows non-static declaration
/var/lib/builder/rhevh/source-root/kvm/kernel/x86/../external-module-compat-comm.h:565: error: previous declaration of ‘pci_get_bus_and_slot’ was here
/var/lib/builder/rhevh/source-root/kvm/kernel/x86/../external-module-compat.c:315: error: redefinition of ‘pci_get_bus_and_slot’
include/linux/pci.h:541: error: previous definition of ‘pci_get_bus_and_slot’ was here
make[4]: *** [/var/lib/builder/rhevh/source-root/kvm/kernel/x86/../external-module-compat.o] Error 1
make[3]: *** [/var/lib/builder/rhevh/source-root/kvm/kernel/x86] Error 2
make[2]: Leaving directory `/usr/src/kernels/2.6.18-174.el5-x86_64'
make[2]: *** [_module_/var/lib/builder/rhevh/source-root/kvm/kernel] Error 2
make[1]: *** [all] Error 2
make[1]: Leaving directory `/var/lib/builder/rhevh/source-root/kvm/kernel'
make: *** [kernel] Error 2

Comment 4 Eduardo Habkost 2010-10-13 00:37:26 UTC
Proper fix (fixing bug #641823) is on kvm-83-203.el5.