Bug 539863
| Summary: | Review Request: perl-Pod-PseudoPod - Extending the POD tags for book manuscripts | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gerd Pokorra <gp> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | christoph.wickert, fedora-package-review, lkundrak, notting |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Pod-PseudoPod/ | ||
| Whiteboard: | |||
| Fixed In Version: | 0.15-1.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-12-24 20:39:18 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Gerd Pokorra
2009-11-21 11:43:36 UTC
The URL of the latest scratch build is: http://koji.fedoraproject.org/koji/taskinfo?taskID=1830099 The "BuildArch is set to "noarch". The file under the Spec-URL is updated. ftp://ftp.uni-siegen.de/pub/parrot.rpms/PseudoPod/perl-Pod-PseudoPod.spec You can find latest SRPM at the URL: ftp://ftp.uni-siegen.de/pub/parrot.rpms/PseudoPod/perl-Pod-PseudoPod-0.15-1.fc11.src.rpm The latest scratch build is: http://koji.fedoraproject.org/koji/taskinfo?taskID=1830833 The rpmlint output reports: 0 errors, 0 warnings Changed the basis to an autogenerated specfile. ExtUtils::MakeMaker is replaced with Module::Build. The file under the URLs are updated: ftp://ftp.uni-siegen.de/pub/parrot.rpms/PseudoPod/perl-Pod-PseudoPod.spec ftp://ftp.uni-siegen.de/pub/parrot.rpms/PseudoPod/perl-Pod-PseudoPod-0.15-1.fc11.src.rpm The latest scratch build is: http://koji.fedoraproject.org/koji/taskinfo?taskID=1838062 The rpmlint output reports: 0 errors, 0 warnings * Named and versioned in accordance with guidelines
* License tag correct, license ok
* SPEC file clean and legible
* Builds fine in mock
* RPMlint silent and happy
* Dependencies sane
* Source archive matches upstream
Nothing that would block the issues,
the package is
APPROVED
A few small suggestions:
1.) You do not need to explicitly require perl(HTML::Entities)
It's automatically in by autoreq (you probably still need the rest, as you seem to need specific versions).
2.) You have redundant entries in %files, even RPM complains:
warning: File listed twice: /usr/share/perl5/Pod/PseudoPod/Checker.pm
warning: File listed twice: /usr/share/perl5/Pod/PseudoPod/DocBook.pm
There are two solutions to the problem. One is prepending the "%{perl_vendorlib}/Pod/PseudoPod" line with "%doc" so that RPM doesn't automatically add its descendants recursively. Alternatively, you can leave the line as is and remove all its descendants below.
Few little changes are made, which reflect the suggestions. The URLs and version number remain the same. New Package CVS Request ======================= Package Name: perl-Pod-PseudoPod Short Description: Framework for extending the POD tags for book manuscripts Owners: gerd Branches: F-11 F-12 InitialCC: gerd cvs done. perl-Pod-PseudoPod-0.15-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/perl-Pod-PseudoPod-0.15-1.fc12 perl-Pod-PseudoPod-0.15-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/perl-Pod-PseudoPod-0.15-1.fc11 perl-Pod-PseudoPod-0.15-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. perl-Pod-PseudoPod-0.15-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. New Package CVS Request ======================= Package Name: perl-Pod-PseudoPod Owners: gerd Branches: EL-5 This is the correct form: Package Change Request ====================== Package Name: perl-Pod-PseudoPod New Branches: EL-5 Owners: gerd Package Change Request ====================== Package Name: perl-Pod-PseudoPod New Branches: EL-5 Owners: gerd This package also builds on the EL-5 brunch. You can see it at this scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1955811 Yes, thats the correct form. ;) Thanks. cvs done. "EL-5 brunch". Love that :) Sorry, I couldn't help myself |