Bug 539921
Summary: | Only dim diplay when power supply changes | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Byron Clark <byron> | ||||
Component: | DeviceKit-power | Assignee: | Richard Hughes <richard> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | low | ||||||
Version: | 12 | CC: | amcnabb, richard | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | i686 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2009-11-25 21:15:55 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
Byron Clark
2009-11-21 16:12:17 UTC
This is a little more bizarre than expected. The screen continues to dim, even when I turn off the "Dim display when idle" checkbox in the "On Battery Power" section of the gnome-power-manager preferences. Watching the output of 'devkit-power --monitor-detail' shows messages like this every time the display dims: daemon changed: daemon-version: 012 can-suspend: yes can-hibernate yes on-battery: yes on-low-battery: yes lid-is-closed: no lid-is-present: yes daemon changed: daemon-version: 012 can-suspend: yes can-hibernate yes on-battery: yes on-low-battery: no lid-is-closed: no lid-is-present: yes It appears that the on-low-battery state is changing even though the battery is approximately 80% full. Changed title to reflect what the real problem is. gnome-power-manager attempts to change the brightness whenever it gets a message from DeviceKit-power showing a change when on-battery is set to yes. At least on my system these messages happen when the power supply hasn't changed. I guess the fix would be to get gnome-power-manager to check the last power supply state before attempting to dim or get DeviceKit-power to not send the spurious messages. I have a Samsung NC10 and saw the same problem. There was an auto-dimming setting in the BIOS that I flipped to get rid of the confusing behavior. It's not really a solution, but it's a pretty good workaround. The BIOS setting Andrew mentions is "Brightness Mode Control". Setting that to "User Control" instead of "Auto" greatly reduces the frequency at which the screen dims, but it still dims whenever one of those extra change messages comes through. Created attachment 373821 [details]
Extract percentage using the correct type.
The problem was DeviceKit-power using a guint to extract the percentage in the on-low-battery calculation. The resulting value would be either 0 or -1 depending on the charge percentage. The attached patch fixes the problem in DeviceKit-power.
Patch applied, thanks. |