Bug 539948

Created attachment 372777 [details]
fqterm-0.9.5.2-0.fc12.src.rpm

Created attachment 372778 [details]
fqterm.spec

Please see http://fedoraproject.org/wiki/PackageReviewProcess for setting the proper component and flags for a review.

small suggestion, leave out "based on Qt library on linux" from package description/summary.  We already know it's linux, and 99% of users won't need to know or care what toolkit the app is written for.

Hello, thanks for the suggestion.
I modified the package description/summary and fix the SPEC file(%cmake -> %cmake-DBUILD_SHARED_LIBS:BOOL=OFF ) for 'requires' problem.
SPEC file: http://dl.dropbox.com/u/1338197/1/fqterm-0.9.5.2-1.fc12.src.rpm
SRPM file: http://dl.dropbox.com/u/1338197/1/fqterm.spec

SPEC file clean up.

SPEC: http://dl.dropbox.com/u/1338197/2/fqterm.spec
SRPM: http://dl.dropbox.com/u/1338197/2/fqterm-0.9.5.2-2.fc12.src.rpm

New upstream 0.9.6.3
SPEC: http://dl.dropbox.com/u/1338197/1/fqterm.spec
SRPM: http://dl.dropbox.com/u/1338197/1/fqterm-0.9.6.3-1.fc12.src.rpm

I can review this,

naming: ok

licensing: ok, though please confirm with upstream, sources contain GPLv2+ (or later) clause.

runtime: ok, though I'd suggest adding a runtime dependency,
%{?_qt4_version:Requires: qt4%{?_isa} >= %{_qt4_version}}

$ rpmlint *.rpm x86_64/*.rpm
fqterm.src: W: spelling-error %description -l en_US login -> loin, logic, lo gin
fqterm.src: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes
fqterm.src: W: invalid-url Source0: http://fqterm.googlecode.com/files/fqterm-0.9.6.3.tar.gz HTTP Error 404: Not Found
fqterm.x86_64: W: spelling-error %description -l en_US login -> loin, logic, lo gin
fqterm.x86_64: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes
fqterm.x86_64: E: backup-file-in-package /usr/share/FQTerm/userconf/address.cfg.orig
fqterm.x86_64: E: non-executable-script /usr/share/FQTerm/fqterm.sh 0644L /bin/sh
fqterm.x86_64: E: backup-file-in-package /usr/share/FQTerm/userconf/language.cfg.orig
fqterm.x86_64: E: backup-file-in-package /usr/share/FQTerm/userconf/fqterm.cfg.orig
3 packages and 0 specfiles checked; 4 errors, 5 warnings.

These seem mostly harmless, though probably should omit the *.orig files from packaging.

sources: ok
$ md5sum *.gz
d9415c20eb1df1be168a465025e41fbc  fqterm-0.9.6.3.tar.gz

.desktop file: ok, though I see you're using legacy/deprecated /usr/share/pixmaps for icon.  I'd recommend using the newer, themeable /usr/share/icons  instead.

%build: please document why -DBUILD_SHARED_LIBS:BOOL=OFF  is used.  a short .spec comment is sufficient

macros: ok

scriptlets: ok



please address items raised here, and we'll be close to approval.

Thanks for review.

Update to 0.9.6.8
SPEC: http://dl.dropbox.com/u/1338197/1/fqterm.spec
SRPM: http://dl.dropbox.com/u/1338197/1/fqterm-0.9.6.8-1.fc12.src.rpm    

rpmlint fqterm-0.9.6.8-1.fc12.i686.rpm fqterm-debuginfo-0.9.6.8-1.fc12.i686.rpm 
fqterm.i686: W: spelling-error %description -l en_US login -> loin, logic, lo gin
fqterm.i686: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes
fqterm.i686: E: backup-file-in-package /usr/share/FQTerm/userconf/address.cfg.orig
fqterm.i686: E: backup-file-in-package /usr/share/FQTerm/userconf/language.cfg.orig
fqterm.i686: E: backup-file-in-package /usr/share/FQTerm/userconf/fqterm.cfg.orig

.orig file are useful in this package, they are backup files for user configurable data.



See /usr/share/FQTerm/userconf/README.txt

OK, all looks good, APPROVED.

No response marking as stalled review per,
http://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

please to ping back and re-open if you want to pursue this further.