Bug 539948

Summary: Review Request: fqterm ---BBS client based on Qt library in linux
Product: [Fedora] Fedora Reporter: Chen Lei <supercyper1>
Component: Package ReviewAssignee: Rex Dieter <rdieter>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, notting, rdieter, supercyper1
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://code.google.com/p/fqterm/
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-09-02 11:09:12 EDT Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449    
Description Flags
fqterm.spec none

Description Chen Lei 2009-11-21 13:10:19 EST
BBS client writtern in QT4

FQTerm is one of the most widely used BBS client in China, it
supports telnet/ssh1/ssh2 protocols and can process ANSI control
sequences. It can be used to login BBS sites or *NIX hosts.

Almost all the BBSes in Greater China Region are in BIG5 or GBK
encoding. So FQTerm only support these two encodings and ASCII.
Comment 1 Chen Lei 2009-11-21 13:11:28 EST
Created attachment 372777 [details]
Comment 2 Chen Lei 2009-11-21 13:16:48 EST
Created attachment 372778 [details]
Comment 3 Todd Zullinger 2009-11-21 13:24:57 EST
Please see http://fedoraproject.org/wiki/PackageReviewProcess for setting the proper component and flags for a review.
Comment 4 Rex Dieter 2009-11-21 19:23:17 EST
small suggestion, leave out "based on Qt library on linux" from package description/summary.  We already know it's linux, and 99% of users won't need to know or care what toolkit the app is written for.
Comment 5 Chen Lei 2009-11-22 01:13:37 EST
Hello, thanks for the suggestion.
I modified the package description/summary and fix the SPEC file(%cmake -> %cmake-DBUILD_SHARED_LIBS:BOOL=OFF ) for 'requires' problem.
SPEC file: http://dl.dropbox.com/u/1338197/1/fqterm-
SRPM file: http://dl.dropbox.com/u/1338197/1/fqterm.spec
Comment 8 Rex Dieter 2010-04-28 10:59:18 EDT
I can review this,

naming: ok

licensing: ok, though please confirm with upstream, sources contain GPLv2+ (or later) clause.

runtime: ok, though I'd suggest adding a runtime dependency,
%{?_qt4_version:Requires: qt4%{?_isa} >= %{_qt4_version}}

$ rpmlint *.rpm x86_64/*.rpm
fqterm.src: W: spelling-error %description -l en_US login -> loin, logic, lo gin
fqterm.src: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes
fqterm.src: W: invalid-url Source0: http://fqterm.googlecode.com/files/fqterm- HTTP Error 404: Not Found
fqterm.x86_64: W: spelling-error %description -l en_US login -> loin, logic, lo gin
fqterm.x86_64: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes
fqterm.x86_64: E: backup-file-in-package /usr/share/FQTerm/userconf/address.cfg.orig
fqterm.x86_64: E: non-executable-script /usr/share/FQTerm/fqterm.sh 0644L /bin/sh
fqterm.x86_64: E: backup-file-in-package /usr/share/FQTerm/userconf/language.cfg.orig
fqterm.x86_64: E: backup-file-in-package /usr/share/FQTerm/userconf/fqterm.cfg.orig
3 packages and 0 specfiles checked; 4 errors, 5 warnings.

These seem mostly harmless, though probably should omit the *.orig files from packaging.

sources: ok
$ md5sum *.gz
d9415c20eb1df1be168a465025e41fbc  fqterm-

.desktop file: ok, though I see you're using legacy/deprecated /usr/share/pixmaps for icon.  I'd recommend using the newer, themeable /usr/share/icons  instead.

%build: please document why -DBUILD_SHARED_LIBS:BOOL=OFF  is used.  a short .spec comment is sufficient

macros: ok

scriptlets: ok

please address items raised here, and we'll be close to approval.
Comment 9 Chen Lei 2010-04-28 22:44:12 EDT
Thanks for review.

Update to
SPEC: http://dl.dropbox.com/u/1338197/1/fqterm.spec
SRPM: http://dl.dropbox.com/u/1338197/1/fqterm-    

rpmlint fqterm- fqterm-debuginfo- 
fqterm.i686: W: spelling-error %description -l en_US login -> loin, logic, lo gin
fqterm.i686: W: spelling-error %description -l en_US encodings -> encoding, encoding s, encodes
fqterm.i686: E: backup-file-in-package /usr/share/FQTerm/userconf/address.cfg.orig
fqterm.i686: E: backup-file-in-package /usr/share/FQTerm/userconf/language.cfg.orig
fqterm.i686: E: backup-file-in-package /usr/share/FQTerm/userconf/fqterm.cfg.orig

.orig file are useful in this package, they are backup files for user configurable data.

See /usr/share/FQTerm/userconf/README.txt
Comment 10 Rex Dieter 2010-08-09 17:55:00 EDT
OK, all looks good, APPROVED.
Comment 11 Rex Dieter 2011-09-02 11:09:12 EDT
No response marking as stalled review per,

please to ping back and re-open if you want to pursue this further.