Bug 540368 (llk_linux)

See http://allmyapps.com/app/ubuntu-9.10/llk-linux-llk_linux for More informations and screenshots.

md5sum of tar inside does not match with upstream tar which is referenced in Source.

Hi Jan， sorry for my late reply.
I have updated the tar with right md5sum in the src.rpm.
SPEC: http://dl.dropbox.com/u/1338197/1/llk_linux.spec
SRPM: http://dl.dropbox.com/u/1338197/1/llk_linux-2.3-0.1.beta1.fc12.src.rpm

1] Please bump Release each time you perform any change into spec file

2] In spec file you have:
Version:	2.3
Release:	0.1.beta1%{?dist}

However, version of llk is 2.3beta1
Imho you should have following in spec file (and update Source link to reflect this): 
Version: 2.3beta1
Release: 1%{?dist}

And bump Release each change in spec file
(so now it should be:
Release: 2%{?dist}
next version should have:
Release: 3%{?dist}
etc...)

3] Are compiler flags honored in Makefile by default?
If no, you should honor them correctly
http://fedoraproject.org/wiki/Packaging/Guidelines#Compiler_flags

4] if possible, you should use following way how to install desktop file
http://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage

5] comments in files section should be removed

Thankkee Jan! I modified my spec files.
New spec and SRPMS
SPEC: http://dl.dropbox.com/u/1338197/1/llk_linux.spec
SRPM: http://dl.dropbox.com/u/1338197/1/llk_linux-2.3-0.2.beta1.fc12.src.rpm

Some changes
1.
I bumpd the release from 0.1.beta1%{?dist} to 0.2.beta1%{?dist}.
2.
I think the version of llk_linux should retain 2.3 rather than 2.3beta1, beta1 should in the release number.
See http://fedoraproject.org/wiki/Packaging:NamingGuidelines#NonNumericRelease
3.
This package successfully honored compiler flags in Makefile by default, so we do not need to set $RPM_OPT_FLAGS/%{optflags}
4.
I followed the guideline to intall desktop file, however the desktop file still need some additional modification such as adding a key to the desktop file or changing the content of a key that cannot accomplished by desktop-file-intall.
5.
I removed comments in files section.

The package from comment 5 fails to build for me:

gcc -pthread -I/usr/include/gtk-2.0 -I/usr/lib64/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -pthread -Wall -g -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic -o llk_linux main.o llk_about.o llk_algorithm.o llk_inifile.o create_pak.o pak.o eggtrayicon.o tray.o -pthread  -lgtk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lfreetype -lfontconfig -lgdk-x11-2.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lm -lpango-1.0 -lcairo -lgobject-2.0 -lgmodule-2.0 -lpng12 -lgthread-2.0 -lrt -lglib-2.0 -lc -lesd
/usr/bin/ld: eggtrayicon.o: undefined reference to symbol 'XFlush'
/usr/bin/ld: note: 'XFlush' is defined in DSO /usr/lib64/libX11.so.6 so try adding it to the linker command line
/usr/lib64/libX11.so.6: could not read symbols: Invalid operation

Failed koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2599474

No buildable package in 18+ months; closing.