Bug 540539
| Summary: | Review Request: gpdftext - Ebook PDF editor | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rahul Sundaram <sundaram> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | christoph.wickert, fedora-package-review, mail, notting, sergio.pasra, smohan, tomspur |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-12-17 15:26:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Rahul Sundaram
2009-11-23 15:54:26 UTC
Scratch build at http://koji.fedoraproject.org/koji/taskinfo?taskID=1826212 Just a few comments for now: - Why do you provide a own desktop file? The original desktop file will be translated, your provided one probably never. You should patch the desktop file and send your patch upstream to correct the missing ';'... - The desktop file contains a mime type: see https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database Yes, upstream has been notified about the problems in the supplied desktop file and it has been fixed for the upstream release. It is not just the missing semi colons. I have provided my own as a temporary workaround update-desktop-database has been added. http://sundaram.fedorapeople.org/packages/gpdftext.spec http://sundaram.fedorapeople.org/packages/gpdftext-0.0.2-2.fc12.src.rpm Why not use a quick sed fix as described in https://fedoraproject.org/wiki/PackageMaintainers/PackagingTricks#.desktop_files ? I prefer not using sed since the file can change upstream without me noticing with undesirable side effects. Anyway, it is temporary workaround since upstream is releasing a new version soon. 0.1.0 was released some times ago. 0.1.1 is out. |