Bug 540885 (cableswig)
| Summary: | Review Request: CableSwig - Create interfaces to interpreted languages for templated code | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Mario Ceresa <mrceresa> |
| Component: | Package Review | Assignee: | Peter Lemenkov <lemenkov> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, lemenkov, mrceresa, notting |
| Target Milestone: | --- | Flags: | lemenkov:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | CableSwig-3.20.0-3.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-10-17 04:50:49 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Mario Ceresa
2009-11-24 13:09:10 UTC
Do you have any place which you can put your spec/srpm on and we can download them by wget (for example) directly from? If not, you can check: https://fedoraproject.org/wiki/Fedorapeople.org and you can have about 150 MiB on fedorapeople.org. Hello Mamoru, thanks for your comment. I looked at fedora people, but it seems I'd need to be already sponsored in order to get the space. A friend of mine could host them for a while at: ftp://85.54.198.199/FEDORA/cableswig-cvs20091120-1.fc12.src.rpm ftp://85.54.198.199/FEDORA/cableswig.spec ftp://85.54.198.199/FEDORA/InsightToolkit-3.16.0-1.fc12.src.rpm ftp://85.54.198.199/FEDORA/InsightToolkit.spec I'm looking forward to hearing from you soon, Mario Removing FE-NEEDSPONSOR - I just sponsored Mario I'll review it. Thanks to Peter sponsorship I could activate my fedorapeople account. Thus from now on the updated srpms/spec locations will be: http://mrceresa.fedorapeople.org/cableswig.spec http://mrceresa.fedorapeople.org/cableswig-cvs20091120-1.fc12.src.rpm Mario Updated to new relase (3.16): http://mrceresa.fedorapeople.org/CableSwig-ITK-3.16.0-2.fc12.src.rpm http://mrceresa.fedorapeople.org/CableSwig-ITK.spec Fixed install paths: http://mrceresa.fedorapeople.org/CableSwig-ITK-3.16.0-3.fc12.src.rpm http://mrceresa.fedorapeople.org/CableSwig-ITK.spec Updated to new release (3.20): http://mrceresa.fedorapeople.org/CableSwig-3.20.0-1.fc12.src.rpm http://mrceresa.fedorapeople.org/CableSwig.spec I also changed the name to CableSwig because this is the way developers refers to it. Removed "dist" tag from changelog: http://mrceresa.fedorapeople.org/CableSwig-3.20.0-2.fc12.src.rpm http://mrceresa.fedorapeople.org/CableSwig.spec Builds correctly in mock and koji (i686 and x86_64): https://koji.fedoraproject.org/koji/taskinfo?taskID=2474720 Hello Peter, thanks for your work on removing GCC, GCC-XML and expat from the bundled libraries. Even if we need to work a little bit more the patch to remove expat, I updated the location of the packages with what we've done so far: http://mrceresa.fedorapeople.org/CableSwig-3.20.0-3.fc12.src.rpm http://mrceresa.fedorapeople.org/CableSwig.spec Hello Peter, here there are the new files: http://mrceresa.fedorapeople.org/CableSwig.spec http://mrceresa.fedorapeople.org/CableSwig-3.20.0-3.fc12.src.rpm they also build with koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2482718 Ok, good.
REVIEW:
Legend: + = PASSED, - = FAILED, 0 = Not Applicable
+ rpmlint is almost silent
Sulaco ~: rpmlint Desktop/CableSwig-*
CableSwig.ppc: W: spelling-error Summary(en_US) templated -> templates, template, temp lated
CableSwig.ppc: W: no-documentation
CableSwig.ppc: W: no-manual-page-for-binary cswig
CableSwig.ppc: W: no-manual-page-for-binary cableidx
2 packages and 0 specfiles checked; 0 errors, 4 warnings.
Sulaco ~:
+ The package is named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format %{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the Licensing Guidelines .
+ The License field in the package spec file matches the actual license. (BSD)
+ The file, containing the text of the license(s) for the package, is included in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as provided in the spec URL.
Sulaco ~/rpmbuild/SOURCES: sha256sum CableSwig-ITK-3.20.0.tar.gz*
0faef127a9881212faf3e9105d77637ba124cc48d10446005a515ed2502828b6 CableSwig-ITK-3.20.0.tar.gz
0faef127a9881212faf3e9105d77637ba124cc48d10446005a515ed2502828b6 CableSwig-ITK-3.20.0.tar.gz.1
Sulaco ~/rpmbuild/SOURCES:
+ The package successfully compiles and builds into binary rpms on at least one primary architecture. See koji link above.
+ All build dependencies are listed in BuildRequires.
0 No need to handle locales.
0 The package does not store shared library files in any of the dynamic linker's default paths.
+/- The package does bundle copy of application, already available in Fedora, - SWIG. But the whole idea of CableSwig is to fork SWIG and deeply patch it. More to say - SWIG doesn't provide a library to ling against it, so if anyone would like to re-use SWIG codebase, then there is no other way when forking it. So this is NOT a blocker.
0 The package is NOT designed to be relocatable.
+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files listings.
+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files.
+ Anything, the package includes as %doc, does not affect the runtime of the application.
0 No C/CPP header files.
0 No static libraries.
0 The package does not contain library files.
0 No devel sub-package
+ The package does NOT contain any .la libtool archives.
0 Not a GUI application
+ The packages does not own files or directories already owned by other packages.
+ All filenames in rpm packages are valid UTF-8.
This package is
APPROVED.
New Package SCM Request ======================= Package Name: CableSwig Short Description: Create interfaces to interpreted languages for templated code Owners: mrceresa Branches: f12 f13 f14 el6 el5 InitialCC: mrceresa The Bug summary and package name in the request don't match up. ;( Can you fix the bug summary or name in the request and reset the fedora-cvs flag? Hello Kevin, sorry for the mispelling. Is this right now? Thanks Mario New Package SCM Request ======================= Package Name: CableSwig Short Description: Create interfaces to interpreted languages for templated code Owners: mrceresa Branches: f12 f13 f14 el6 el5 InitialCC: mrceresa Git done (by process-git-requests). CableSwig-3.20.0-3.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/CableSwig-3.20.0-3.fc12 CableSwig-3.20.0-3.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/CableSwig-3.20.0-3.fc13 CableSwig-3.20.0-3.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update CableSwig'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/CableSwig-3.20.0-3.fc13 CableSwig-3.20.0-3.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. CableSwig-3.20.0-3.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. CableSwig-3.20.0-3.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/CableSwig-3.20.0-3.fc14 CableSwig-3.20.0-3.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |