Bug 540921
| Summary: | emacs FTBFS on F12 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Praveen Arimbrathodiyil <parimbra> | ||||
| Component: | emacs | Assignee: | Daniel Novotny <dnovotny> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 12 | CC: | debarshir, dnovotny, jakub, jan.h.d, jonathan.underwood, llim, pnemade, psatpute, tagoh | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 23.1-12.fc12 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2009-12-02 04:29:47 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Praveen Arimbrathodiyil
2009-11-24 14:23:25 UTC
its strange, it is failing in koji as well whicle scratch build see build log http://koji.fedoraproject.org/koji/getfile?taskID=1829990&name=build.log what is the problem? the issue is not using newline escape character ('\') when multiline values are assigned to variables
submitted upstream http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=5047 Just for the simple testcases: 1) cpp --version 2) /bin/echo -e 'obj= foo \\\n\tbar \\\n\tbaz\n' | cpp on F-11: 1) cpp (GCC) 4.4.1 20090725 (Red Hat 4.4.1-2) 2) obj= foo bar baz on F-12: 1) cpp (GCC) 4.4.2 20091027 (Red Hat 4.4.2-7) 2) obj= foo bar baz This result explains why it didn't happen on F-11 but on F-12 or later. it looks like cpp issue to me because it's used to pre-process something. cpp shouldn't expect any parsers can read it with/without the backslash at the end of line. IMHO it would be better keep it as is. the backslashes shouldn't be lost reassigning to cpp, i.e. gcc package FWIW, this is fixed in later Emacs versions (unreleased CVS version):
2009-10-23 Jim Meyering <meyering>
* configure.in: Invoke $CPP with -P when creating Makefile and
src/Makefile. Without this, gcc 4.4.2 converts each
backslash-newline pair in the input to a bare newline, yielding
invalid Makefiles.
Watch:
% cpp --version
cpp (GCC) 4.4.2 20091027 (Red Hat 4.4.2-7)
% /bin/echo -e 'obj= foo \\\n\tbar \\\n\tbaz\n' | cpp
obj= foo bar baz
OK, I'll reassign this to myself and backport the change Created attachment 374742 [details]
configure.in patch
you also have to run "autoconf" in %build section of the spec to regenerate "configure"
Thanks all for their work. Its nice that we have found solution. Can we have this backported to F-12 as well and have a new koji build release? It took me some time to find actually what commit was happened in git but I got it here -> http://github.com/davidswelt/aquamacs-emacs/commit/7ffa22b0da2005b1ad04f9884dd154de2821e8d7 (In reply to comment #9) > Thanks all for their work. Its nice that we have found solution. Can we have > this backported to F-12 as well and have a new koji build release? yes, we will build new F12 and F13 release rawhide(F-13) build is now finished (emacs-23.1-14.fc13), F12 update will follow emacs-23.1-12.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/emacs-23.1-12.fc12 emacs-23.1-12.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. |