Bug 541213

Summary: Possible access to invalid memory
Product: Red Hat Enterprise Linux 5 Reporter: Vitaliy Gusev <vgusev>
Component: kernelAssignee: Prarit Bhargava <prarit>
Status: CLOSED ERRATA QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: medium Docs Contact:
Priority: low    
Version: 5.4CC: agospoda, dzickus, jwilson, khorenko, pbenas
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-03-30 07:45:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
RHEL5 fix for this issue none

Description Vitaliy Gusev 2009-11-25 09:29:12 UTC
Description of problem:

 During compilation kernel-2.6.18-164.6.1.el5 I've seen warning:

  CHK     include/linux/version.h
  CHK     include/linux/utsrelease.h
  CC      net/ipv4/route.o
 net/ipv4/route.c:3318: warning: initialization from incompatible pointer type
  LD      net/ipv4/built-in.o


Version-Release number of selected component (if applicable):

   kernel-2.6.18-164.6.1.el5 sources


Additional info:

 I investigated and see that in route.c in the line 3318 has:

      	.strategy	= &ipv4_sysctl_rt_secret_interval_strategy,

.strategy is declared as ctl_handler:

 typedef int ctl_handler (struct ctl_table *table, int __user *name, int nlen,
			 void __user *oldval, size_t __user *oldlenp,
			 void __user *newval, size_t newlen);

But

  static int ipv4_sysctl_rt_secret_interval_strategy(ctl_table *table,
						   void __user *oldval,
						   size_t __user *oldlenp,
						   void __user *newval,
						   size_t newlen)

Comment 1 Prarit Bhargava 2009-12-03 14:24:55 UTC
Right ... I've fixed a few of these.  I guess I can see about fixing this one too.

P.

Comment 2 Prarit Bhargava 2009-12-03 17:03:27 UTC
Created attachment 375841 [details]
RHEL5 fix for this issue

Comment 3 RHEL Program Management 2009-12-15 03:12:16 UTC
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 4 Don Zickus 2009-12-16 19:02:04 UTC
in kernel-2.6.18-182.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5

Please update the appropriate value in the Verified field
(cf_verified) to indicate this fix has been successfully
verified. Include a comment with verification details.

Comment 7 Petr Beňas 2010-03-24 14:08:02 UTC
VERIFIED
(after release_pending)

kernel-2.6.18-181.el5 compiling:
net/ipv4/route.c:3321: warning: initialization from incompatible pointer type

kernel-2.6.18-182.el5 compiling: 
  LD [M]  net/ieee80211/softmac/ieee80211softmac.o
  CC      net/ipv4/route.o
  CC      net/ipv4/inetpeer.o

Comment 8 errata-xmlrpc 2010-03-30 07:45:53 UTC
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2010-0178.html