Bug 541664

Summary:	Merge Review: perl-Test-Pod - Perl module for checking for POD errors in files
Product:	[Fedora] Fedora	Reporter:	Marcela Mašláňová <mmaslano>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	fedora-package-review, notting, panemade, tremble
Target Milestone:	---	Flags:	panemade: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2009-12-10 11:09:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Marcela Mašláňová 2009-11-26 16:49:15 UTC

SRPM: http://mmaslano.fedorapeople.org/MergeReview/perl-Test-Pod-1.40-1.fc13.src.rpm
Spec: http://mmaslano.fedorapeople.org/MergeReview/perl-Test-Pod.spec
Description: Perl module for checking for POD errors in files

Comment 1 Parag AN(पराग) 2009-11-27 09:32:52 UTC

I wonder how can this package got missed at time of FC-6 when all core packages submitted for their merge-reviews.

Comment 2 Parag AN(पराग) 2009-12-09 06:06:38 UTC

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=1863816
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url (sha1sum)
1d833844267dfbb01880b7e0112e325e6ae992b1  Test-Pod-1.40.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=12, Tests=22,  1 wallclock secs ( 0.05 usr  0.01 sys +  0.56 cusr  0.06 csys =  0.68 CPU)
+ Package  perl-Test-Pod-1.40-1.fc13.noarch =>
Provides: perl(Test::Pod) = 1.40 perl(Test::Pod::_parser)
Requires: perl >= 0:5.008 perl(File::Spec) perl(Test::Builder) perl(base) perl(strict)

+ Not a GUI application

Should:
1) Correct license is "GPLv2 or Artistic 2.0"

APPROVED.

Comment 3 Marcela Mašláňová 2009-12-10 11:09:12 UTC

Thanks for your review.

Comment 4 Mark Chappell 2010-09-03 08:25:13 UTC

Package Change Request
======================
Package Name: perl-Test-Pod
New Branches: EL-6
Owners: tremble iarnell spot

Yet another some arches only perl package.

Comment 5 Mark Chappell 2010-09-03 09:47:27 UTC

No it's not, it's just a version issue.