Bug 542165

scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1834451

Do we really need the jdk14 jar? We are not shipping 1.4 jdk and TBH I don't believe it is even used nowadays.

Also I would like to see javadoc subpackage. For me the correct ant call to build only java 5 and javadocs is `ant dist-15 javadocs`.

SPECS: http://v3.sk/~lkundrak/SPECS/testng.spec
SRPMS: http://v3.sk/~lkundrak/SRPMS/testng-5.10-2.fc12.src.rpm

Review:

FIXIT: rpmlint is not happy
testng.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/testng-5.10/README
OK: The package must be named according to the Package Naming Guidelines .
OK: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. 
OK: The package must meet the Packaging Guidelines .
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK: The License field in the package spec file must match the actual license. 
OK If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
OK: The spec file must be written in American English. 
OK: The spec file for the package MUST be legible. [6]
OK: The sources used to build the package must match the upstream source, as provided in the spec URL. 
OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture. 
OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
OK: A package must own all directories that it creates.
OK: A Fedora package must not list a file more than once in the spec file's %files listings. 
OK: Permissions on files must be set properly. 
OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
OK: Each package must consistently use macros. 
OK: The package must contain code, or permissable content. 
OK: Large documentation files must go in a -doc subpackage.
OK: If a package includes something as %doc, it must not affect the runtime of the application. 
OK: Packages must not own files or directories already owned by other packages. 
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). 
OK: All filenames in rpm packages must be valid UTF-8. 

Non blockers but I would love to see them:
1. Maven pom and depmaps added - This will allow me to build testng support in maven-surefire which is disabled now.
2. Testng 5.11 is out - nice to import latest version directly

Thanks for the review.

(In reply to comment #5)
> Review:
> 
> FIXIT: rpmlint is not happy
> testng.noarch: W: wrong-file-end-of-line-encoding
> /usr/share/doc/testng-5.10/README

Fixed.

> Non blockers but I would love to see them:
> 1. Maven pom and depmaps added - This will allow me to build testng support in
> maven-surefire which is disabled now.

Done. (at least attempted to :)

> 2. Testng 5.11 is out - nice to import latest version directly  

Done.

New package:

SPECS: http://v3.sk/~lkundrak/SPECS/testng.spec
SRPMS: http://v3.sk/~lkundrak/SRPMS/testng-5.11-1.fc13.src.rpm

Please include a pom file e.g. http://repo2.maven.org/maven2/org/testng/testng/5.10/testng-5.10.pom. Just change the version to 5.11. 
https://fedoraproject.org/wiki/Packaging:Java#maven contains a sample pom installation.

Definitely not a blocker.

APPROVED

Thank you. I'll include the POM upon import.

New Package CVS Request
=======================
Package Name: testng
Short Description: Java-based testing framework
Owners: lkundrak
Branches: F-11 F-12 EL-5

cvs done.

Thank you for the review.
Imported (with pom) and built.