Bug 542866

Summary: Uses cupsSetPasswordCB() which is not reliable with threads
Product: [Fedora] Fedora Reporter: Kyle Pablo <kylepablo>
Component: system-config-printerAssignee: Tim Waugh <twaugh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 12CC: bugzilla.acct, dmalcolm, ivazqueznet, james.antill, jonathansteffan, jpopelka, katzj, twaugh
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: abrt_hash:80275b68bf5961677897637ae8134d62d11004f8
Fixed In Version: 1.1.16-8.fc11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 549779 (view as bug list) Environment:
Last Closed: 2010-01-15 22:03:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 549779    
Attachments:
Description Flags
File: backtrace
none
Error after clicking Forward to get to the Choose Driver box.
none
debug.txt none

Description Kyle Pablo 2009-12-01 01:07:59 UTC 
abrt detected a crash.

Comment: Try setup a printer.
Attached file: backtrace
cmdline: python /usr/share/system-config-printer/system-config-printer.py
component: python
executable: /usr/bin/python
kernel: 2.6.31.5-127.fc12.x86_64
package: python-2.6.2-2.fc12
rating: 4
reason: Process was terminated by signal 6
Comment 1 Kyle Pablo 2009-12-01 01:08:02 UTC 
Created attachment 374937 [details]
File: backtrace
Comment 2 Dave Malcolm 2009-12-01 01:57:00 UTC 
Thank you for reporting this bug.

How reproducable is this problem?  If you run the program from a terminal, is an error message printed?

What version of system-config-printer do you have installed?

Looking at the backtrace, it looks like an incorrect usage of Python's internal thread API was detected in Connection_end_allow_threads in frame #4 of thread #1

Reassigning component from "python" to "system-config-printer"
Comment 3 Kyle Pablo 2009-12-01 02:04:16 UTC 
system-config-printer-1.1.13-10.fc12.x86_64
Comment 4 Kyle Pablo 2009-12-01 02:16:44 UTC 
Created attachment 374947 [details]
Error after clicking Forward to get to the Choose Driver box.
Comment 5 Tim Waugh 2009-12-01 12:28:22 UTC 
That error dialog can be ignored and is not related to the main problem here, the crash.

Please run this command from the terminal and try to reproduce the problem:

PYCUPS_DEBUG=1 system-config-printer &>debug.txt

Are you able to reproduce the crash again?  If so, please attach the debug.txt file here.
Comment 6 Kyle Pablo 2009-12-02 00:19:51 UTC 
I cannot reproduce the crash. I've attached debug.txt.
Comment 7 Kyle Pablo 2009-12-02 00:21:18 UTC 
Created attachment 375251 [details]
debug.txt
Comment 8 Tim Waugh 2009-12-03 16:23:18 UTC 
Thanks for the debug.txt -- really I need to see one from a run that shows the error though.

Looking again at the backtrace it's coming from GUI.fetchDevices() fetching local devices.  I can't see anywhere the thread state is mishandled though. :-(

Can you remember anything else about when you originally saw the problem?  What were you trying to do?  Was there anything else unusual that happened?
Comment 9 Dave Malcolm 2009-12-21 19:35:19 UTC 
*** Bug 549008 has been marked as a duplicate of this bug. ***
Comment 10 Tim Waugh 2009-12-22 16:18:53 UTC 
I think this might be fixed by upgrading to system-config-printer-1.1.16-1.fc12 which includes pycups-1.9.47.  The specific change I hope will fix it is the switch to using cupsSetPasswordCB2() instead of cupsSetPasswordCB().
Comment 11 Fedora Update System 2009-12-22 16:31:07 UTC 
system-config-printer-1.1.16-1.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/system-config-printer-1.1.16-1.fc11
Comment 12 Fedora Update System 2009-12-23 21:32:05 UTC 
system-config-printer-1.1.16-1.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-13579
Comment 13 Fedora Update System 2009-12-25 08:23:50 UTC 
system-config-printer-1.1.16-2.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-13156
Comment 14 Fedora Update System 2009-12-25 08:24:40 UTC 
system-config-printer-1.1.16-2.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-13579
Comment 15 Fedora Update System 2010-01-08 19:57:49 UTC 
system-config-printer-1.1.16-6.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-13156
Comment 16 Fedora Update System 2010-01-08 20:13:57 UTC 
system-config-printer-1.1.16-5.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-13579
Comment 17 Fedora Update System 2010-01-12 23:35:44 UTC 
system-config-printer-1.1.16-8.fc11 has been pushed to the Fedora 11 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-13579
Comment 18 Fedora Update System 2010-01-12 23:37:39 UTC 
system-config-printer-1.1.16-8.fc12 has been pushed to the Fedora 12 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update system-config-printer'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-13156
Comment 19 Fedora Update System 2010-01-15 22:02:23 UTC 
system-config-printer-1.1.16-8.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 20 Fedora Update System 2010-01-15 22:10:52 UTC 
system-config-printer-1.1.16-8.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.