Bug 543159

Review:

Good:
- name ok
- latest version packaged
- correctly installing *.mo
- no *.la
- no libs
- %files ok
- %doc ok
- group ok
- %install ok
- rpmlint clean


Needswork:
- BR/R not complete:
  to own the folder %{_datadir}/dbus-1/services:
  Requires: dbus is missing

- License is wrong:
  In COPYRIGHT is mentioned that zeitgeist/loggers/iso_strptime.py is stolen
  and under license LGPLv3 only
  Rest of the *.py headers say LGPLv3+

  -> Correctly license is LGPLv3+ and LGPLv3

  Please mention, that zeitgeist/loggers/iso_strptime.py is LGPLv3 and the rest
  LGPLv3+ in the specfile as a comment.

  see https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios

(In reply to comment #1)
> - BR/R not complete:
>   to own the folder %{_datadir}/dbus-1/services:
>   Requires: dbus is missing

It's not only missing for directory ownership but also to make zeitgeist work. dbus-python and gnome-python2-gconf are missing to, not sure if these are all.

Deji, any update on this?

(In reply to comment #3)
> Deji, any update on this?    

I'm sorry I've been away.

All the issues pointed out above have been addressed, and the package has also been updated to the latest release. Thanks.

Spec URL: http://deji.fedorapeople.org/zeitgeist.spec
SRPM URL: http://deji.fedorapeople.org/zeitgeist-0.3.1-1.fc11.src.rpm

- https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

When you continue using %define, python_sitelib won't be defined some time in the future.

                                                          ########
- Source0 is wrong, use http://launchpad.net/%{name}/0.3/%{version}/+download/%{name}-%{version}.tar.gz instead, till 0.4.x is coming.


- Missing BR: pyxdg, pygobject2, PyXML

Update to new release with some packaging fixes;

Spec URL: http://deji.fedorapeople.org/zeitgeist.spec
SRPM URL: http://deji.fedorapeople.org/zeitgeist-0.3.2-1.fc12.src.rpm

(In reply to comment #6)
> Update to new release with some packaging fixes;

- source matchs upstream: 24348e074b85f49e49a8fdceb29b05b8

- Are you sure, you have all the nessessary BR?
  (Hint: look into zeitgeist-0.3.2/zeitgeist/client.py +30 or just into Comment 5)


Fix that _before_ importing.


###############################

APPROVED

(In reply to comment #7)
> (In reply to comment #6)
> > Update to new release with some packaging fixes;
> 
> - source matchs upstream: 24348e074b85f49e49a8fdceb29b05b8
> 
> - Are you sure, you have all the nessessary BR?
>   (Hint: look into zeitgeist-0.3.2/zeitgeist/client.py +30 or just into Comment
> 5)
> 
> 
> Fix that _before_ importing.
>
That does not a denote a missing BR, if anything it point to a missing runtime 'Requires'.
However the minidom module you're referring to in that file is shipped in the python package, so no need for extra 'Requires'.

> 
> ###############################
> 
> APPROVED 
  
Thanks.

New Package CVS Request
=======================
Package Name: zeitgeist
Short Description: Framework providing Desktop activity awareness
Owners: deji
Branches: F-12
InitialCC:

CVS done (by process-cvs-requests.py).

(In reply to comment #8)
> > - Are you sure, you have all the nessessary BR?
> >   (Hint: look into zeitgeist-0.3.2/zeitgeist/client.py +30 or just into 
> That does not a denote a missing BR, if anything it point to a missing runtime
> 'Requires'.
> However the minidom module you're referring to in that file is shipped in the
> python package, so no need for extra 'Requires'.


Sorry, should be 'R' and not 'BR'.

Hmm, try run:
'''
import xml.dom.minidom
print xml.dom.minidom.__file__
'''

This prints:
/usr/lib64/python2.6/site-packages/_xmlplus/dom/minidom.pyc

$ yum provides /usr/lib64/python2.6/site-packages/_xmlplus/dom/minidom.pyc
[...]
PyXML-0.8.4-15.x86_64 : XML libraries for python
[...]

To what file shippend in the python package are you refering to?

(In reply to comment #11)
> (In reply to comment #8)
> > > - Are you sure, you have all the nessessary BR?
> > >   (Hint: look into zeitgeist-0.3.2/zeitgeist/client.py +30 or just into 
> > That does not a denote a missing BR, if anything it point to a missing runtime
> > 'Requires'.
> > However the minidom module you're referring to in that file is shipped in the
> > python package, so no need for extra 'Requires'.
> 
> 
> Sorry, should be 'R' and not 'BR'.
> 
> Hmm, try run:
> '''
> import xml.dom.minidom
> print xml.dom.minidom.__file__
> '''
> 
> This prints:
> /usr/lib64/python2.6/site-packages/_xmlplus/dom/minidom.pyc
> 
> $ yum provides /usr/lib64/python2.6/site-packages/_xmlplus/dom/minidom.pyc
> [...]
> PyXML-0.8.4-15.x86_64 : XML libraries for python
> [...]
> 
> To what file shippend in the python package are you refering to?    
[deji@rhema ~]$ rpm -q PyXML
package PyXML is not installed
[deji@rhema ~]$ python
Python 2.6.2 (r262:71600, Aug 21 2009, 12:23:57) 
[GCC 4.4.1 20090818 (Red Hat 4.4.1-6)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import xml.dom.minidom
>>> print xml.dom.minidom.__file__
/usr/lib64/python2.6/xml/dom/minidom.pyc
>>> exit()
[deji@rhema ~]$ rpm -q --whatprovides /usr/lib64/python2.6/xml/dom/minidom.pyc
python-2.6.2-2.fc12.x86_64

Built for rawhide and F-12. Thanks for the review.

Excuse me, How am I supposed to use this package? what application use it?

Thanks.