Bug 543337
| Summary: | Review Request: rubygem-rcov - Code coverage analysis tool for Ruby | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matthew Kent <mkent> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mastahnke, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.9.6-2.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-12-07 14:39:39 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Matthew Kent
2009-12-02 07:19:00 UTC
Some notes:
? Requires
- Would you explain the necessity of "R: rubygem(rake)"?
( Maybe for lib/rcov/rcovtask.rb ? If so, I wonder if this
script is used by default or not because no other scripts
in rcov gem seems to require this script )
! Note that I am not objecting to adding "R: rubygem(rake)".
* ext/
- Files under ext/ are to generate C extension module
(rcovrt.so) and should not be needed to be included into
binary rpm.
( The trouble is that once we try to execute "rake check"
under %geminstdir, rake task tries to regenerate .so file.
In such cases files under ext/ are needed, however anyway
this won't work but for root because write permission for
%geminstdir is needed.
So while you may want to add files under ext to -doc
subpackage, these files should not be in main package. )
Thank you for the review (In reply to comment #1) > Some notes: > > ? Requires > - Would you explain the necessity of "R: rubygem(rake)"? > ( Maybe for lib/rcov/rcovtask.rb ? If so, I wonder if this > script is used by default or not because no other scripts > in rcov gem seems to require this script ) > > ! Note that I am not objecting to adding "R: rubygem(rake)". > That's correct, I added that in an attempt to cover what I thought was a missing dependency. Upon a further examination lib/rcov/rcovtask.rb provides tasks *to* rake rather than depending *on* rake. I'll remove that. > * ext/ > - Files under ext/ are to generate C extension module > (rcovrt.so) and should not be needed to be included into > binary rpm. > > ( The trouble is that once we try to execute "rake check" > under %geminstdir, rake task tries to regenerate .so file. > > In such cases files under ext/ are needed, however anyway > this won't work but for root because write permission for > %geminstdir is needed. > So while you may want to add files under ext to -doc > subpackage, these files should not be in main package. ) Good catch, thanks. Spec URL: http://magoazul.com/wip/SPECS/rubygem-rcov.spec SRPM URL: http://magoazul.com/wip/SRPMS/rubygem-rcov-0.9.6-2.fc13.src.rpm * Thu Dec 03 2009 Matthew Kent <mkent> - 0.9.6-2 - Remove Requires for rubygem(rake) (#543337). - Move ext to -doc (#543337). Okay.
------------------------------------------------------------
This package (rubygem-rcov) is APPROVED by mtasaka
------------------------------------------------------------
New Package CVS Request ======================= Package Name: rubygem-rcov Short Description: Code coverage analysis tool for Ruby Owners: mkent Branches: F-11 F-12 InitialCC: cvs done. rubygem-rcov-0.9.6-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/rubygem-rcov-0.9.6-2.fc11 rubygem-rcov-0.9.6-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/rubygem-rcov-0.9.6-2.fc12 Closing. rubygem-rcov-0.9.6-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. rubygem-rcov-0.9.6-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: rubygem-rcov New Branches: el5 el6 Owners: stahnma Git done (by process-git-requests). |