Bug 54350

Summary: rpm-python compilation problems with non-gcc compilers
Product: [Retired] Red Hat Raw Hide Reporter: Gary Benson <gbenson>
Component: rpm-pythonAssignee: Jeff Johnson <jbj>
Status: CLOSED RAWHIDE QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: 1.0   
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2001-12-09 18:38:44 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Gary Benson 2001-10-04 17:26:21 UTC
Obviously neither of these affect builds on Red Hat Linux, but it would be
nice to have them fixed.

Problem 1:
- none of the C files include config.h. This specifically rpmmodule.c.

Solution 1:
- add a #include "system.h" to the top of each C file.
- remove #include <alloca.h> from the top of rpmmodule.c


Problem 2:
- PyObject_HEAD should not be followed by a semicolon.

Solution 2:
- for i in *module.c; do
      mv $i $i.bak
      sed "s/PyObject_HEAD;/PyObject_HEAD/g" < $i.bak > $i
  done

Comment 1 Jeff Johnson 2002-06-05 18:40:53 UTC
Done, changes should be in rpm-4.1-0.23.

Reopen this bug if there are other portability problems.