Bug 543689

Summary:	Package review: libipathverbs - Driver library for libibverbs
Product:	[Fedora] Fedora	Reporter:	Doug Ledford <dledford>
Component:	Package Review	Assignee:	Michael Schwendt <bugs.michael>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	rawhide	CC:	bugs.michael, fedora-package-review, notting
Target Milestone:	---	Flags:	bugs.michael: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-01-03 21:00:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Doug Ledford 2009-12-02 21:14:25 UTC

libipathverbs is a simple package that provides a low level hardware driver for the libibverbs package.  The current package requires libibverbs-1.1.3 or later to compile, and prebuilt versions as well as the spec file and srpm can be found on my person web page at:

http://xsintricity.com/dledford/Package_Review/

rpmlint shows the following:

[dledford@firewall Package_Review]$ rpmlint libipathverbs*
libipathverbs.src:11: W: unversioned-explicit-provides libibverbs-driver
libipathverbs.x86_64: W: non-conffile-in-etc /etc/libibverbs.d/ipath.driver
libipathverbs.spec:11: W: unversioned-explicit-provides libibverbs-driver
libipathverbs-static.x86_64: W: no-documentation
4 packages and 1 specfiles checked; 0 errors, 4 warnings.
[dledford@firewall Package_Review]$ 

The first and third ones are correct as it's a psuedo provides that only exists for the purpose of causing a yum install of libibverbs to pull in all the hardware drivers that make libibverbs operate.

The second is a side effect of the libibverbs package.  It requires the file in this location, but the file is not user changable and should not therefore be labeled as a conf file.

The final one is because the -static package only has one file, the static library.  All the docs are in the base package.

Comment 1 Michael Schwendt 2009-12-05 12:11:25 UTC

The same questions I've added to "libnes" apply here. Not just because of the virtual Provides this looks more like a driver/module/plugin than an ordinary shared library for software development. Without any dependency on a package that provides some headers it's questionable to create the two -devel packages.

Comment 2 Doug Ledford 2009-12-05 15:27:44 UTC

Ditto the responses in the libnes bug.  You are correct that this is a driver plugin or libibverbs and not something directly usable by the user.

Comment 3 Michael Schwendt 2010-06-24 12:08:50 UTC

* Correct Source URL would be:
http://www.openfabrics.org/downloads/libipathverbs/libipathverbs-1.2.tar.gz

$ sha1sum libipathverbs-1.2.tar.gz 
462c07f85b4d568ef72846865ee48ba0af4bb015  libipathverbs-1.2.tar.gz


> Provides: %{name}-devel = %{version}-%{release}

Nowadays, automatic package name "Provides" would also add a second target-specific Provides for %{?_isa}, so also adding that one to explicit Provides would make sense:

%if "no%{?_isa}" != "no"
  Provides: %{name}-devel%{_isa} = %{version}-%{release}
%endif


* openSUSE also build the package for 32-bit and only "ExcludeArch: s390 s390x". A .spec comment explaining your "ExlusiveArch: x86_64" would be helpful.

The spec file included in the tarball is not excluding x86 either. But it may be mistaken, since it also marks /etc/libibverbs.d/ipath.driver as %config, which you've said would be incorrect.


* Verified:

  $ repoquery --whatprovides /etc/libibverbs.d
  libibverbs-0:1.1.3-4.fc13.i686
  libibverbs-0:1.1.3-4.fc13.x86_64

Directory meanwhile is owned correctly by libiverbs.


* ldconfig calls not needed. They would be useless due to the chosen driver library SONAME.


* Placement of the static driver lib in a separate -static subpackage follows the packaging guidelines.


* There are three other libibverbs-driver packages, which are packaged in the same way. Things mentioned in this comment could be fixed in fedora pkg cvs, so:

APPROVED

Comment 4 Doug Ledford 2010-07-09 17:34:55 UTC

Michael, thanks for the review.

Rel-eng: I'd like an F-13 and devel branch for the package.

Comment 5 Kevin Fenzi 2010-07-09 18:15:54 UTC

Please add a cvs template here (see
http://fedoraproject.org/wiki/CVS_admin_requests )

and reset the fedora-cvs flag to ?

Comment 6 Doug Ledford 2010-07-09 19:11:26 UTC

New Package CVS Request
=======================
Package Name: libipathverbs
Short Description: Hardware driver for QLogic iPath hardware, used by libibverbs
Owners: dledford
Branches: F-13,devel
InitialCC:

Comment 7 Kevin Fenzi 2010-07-12 17:15:02 UTC

CVS done (by process-cvs-requests.py).