Bug 543718 (wxmacmolplt)

Summary:	Review Request: wxmacmolplt - A graphics program for plotting 3-D molecular structures and normal modes
Product:	[Fedora] Fedora	Reporter:	Dominik 'Rathann' Mierzejewski <dominik>
Component:	Package Review	Assignee:	Jason Tibbitts <j>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bloch, fedora-package-review, grue, notting
Target Milestone:	---	Flags:	j: fedora-review+ petersen: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	wxmacmolplt-7.4.1-1.fc14	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-12-26 19:52:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dominik 'Rathann' Mierzejewski 2009-12-02 22:43:51 UTC

Spec URL: http://rathann.fedorapeople.org/review/wxmacmolplt.spec
SRPM URL: http://rathann.fedorapeople.org/review/wxmacmolplt-7.4-1.fc11.src.rpm
Description:

MacMolPlt is:
* A modern graphics program for plotting 3-D molecular structures and
  normal modes (vibrations). Modern means:
  o Mouse driven interface for real-time rotation and translation.
  o copy and paste functionality for interfacing to other programs such
    as word processors or other graphics programs (like ChemDraw).
  o simple printing to color or black and white printers (publication
    quality).
  o multiple files open at once.
* It reads a variety of file formats including any GAMESS input, log or
  IRC file directly to create animations of IRC's, DRC's, and
  optimizations. You may also import a $VEC group from any file (such as
  a GAMESS .DAT file). In addition xMol XYZ files, MolDen format files
  and Chemical Markup Language (CML) files are supported. Also some PDB
  file support and MDL MolFile support is included.

Comment 1 Dominik 'Rathann' Mierzejewski 2010-11-13 22:20:54 UTC

Updated:
Spec URL: http://rathann.fedorapeople.org/review/wxmacmolplt.spec
SRPM URL: http://rathann.fedorapeople.org/review/wxmacmolplt-7.4.1-1.fc12.src.rpm

Comment 2 Jason Tibbitts 2010-11-23 16:43:54 UTC

I thought I saw on IRC that someone was going to do a review swap for this, but it's still sitting here in the queue, so...  how about this for a review swap:  I'll review your package, and you can review any other package.  Deal?

Builds fine and rpmlint is completely silent.  Installs and seems to run fine as well.

Note the following from desktop-file-install:

/builddir/build/BUILDROOT/wxmacmolplt-7.4.1-1.fc15.x86_64/usr/share/applications/wxmacmolplt.desktop: error: (will be fatal in the future): value "Chemistry" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: Education;Science

/builddir/build/BUILDROOT/wxmacmolplt-7.4.1-1.fc15.x86_64/usr/share/applications/wxmacmolplt.desktop: error: (will be fatal in the future): value "DataVisualization" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: Education;Science

/builddir/build/BUILDROOT/wxmacmolplt-7.4.1-1.fc15.x86_64/usr/share/applications/wxmacmolplt.desktop: error: (will be fatal in the future): value "Science" in key "Categories" in group "Desktop Entry" requires another category to be present among the following categories: Education

It's probably better to just fix those up now.  It should be an easy fix, so I'll go ahead and approve this and you can take care of it when you check in.

* source files match upstream.  sha256sum:
  61c6a785e9d9b5430fde87d75c7e617637c8a2182741792384c723adcbbae34e
   MacMolPltIcon.gif
  46f594aa33f6e90b79a9ebc4c27e4819749397854aca7c594b79226419c76e63
   wxmacmolplt-7.4.1.tar.gz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* summary is OK.
* description is OK.
* dist tag is present.
* license field matches the actual license.
* license is open source-compatible.
* license text included in package.
* latest version is being packaged.
* BuildRequires are proper.
* compiler flags are appropriate.
* package builds in mock (rawhide, x86_64).
* package installs properly.
* debuginfo package looks complete.
* rpmlint is silent.
* final provides and requires are sane:
   wxmacmolplt = 7.4.1-1.fc15
   wxmacmolplt(x86-64) = 7.4.1-1.fc15
  =
   /bin/sh  
   hicolor-icon-theme  
   libGL.so.1()(64bit)  
   libGLEW.so.1.5()(64bit)  
   libGLU.so.1()(64bit)  
   libgcc_s.so.1()(64bit)  
   libgcc_s.so.1(GCC_3.0)(64bit)  
   libstdc++.so.6()(64bit)  
   libstdc++.so.6(CXXABI_1.3)(64bit)  
   libstdc++.so.6(CXXABI_1.3.1)(64bit)  
   libstdc++.so.6(GLIBCXX_3.4)(64bit)  
   libstdc++.so.6(GLIBCXX_3.4.11)(64bit)  
   libstdc++.so.6(GLIBCXX_3.4.14)(64bit)  
   libstdc++.so.6(GLIBCXX_3.4.9)(64bit)  
   libwx_baseu-2.8.so.0()(64bit)  
   libwx_baseu-2.8.so.0(WXU_2.8)(64bit)  
   libwx_gtk2u_adv-2.8.so.0()(64bit)  
   libwx_gtk2u_adv-2.8.so.0(WXU_2.8)(64bit)  
   libwx_gtk2u_core-2.8.so.0()(64bit)  
   libwx_gtk2u_core-2.8.so.0(WXU_2.8)(64bit)  
   libwx_gtk2u_gl-2.8.so.0()(64bit)  
   libwx_gtk2u_gl-2.8.so.0(WXU_2.8)(64bit)  
   libwx_gtk2u_html-2.8.so.0()(64bit)  
   libwx_gtk2u_html-2.8.so.0(WXU_2.8)(64bit)  

* no bundled libraries.
* no shared libraries are added to the regular linker search paths.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* no generically named files.
* scriptlets are OK (gtk icon cache)
* code, not content.
* documentation is small, so no -doc subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no static libraries.
* no libtool .la files.
X desktop file has a few problems.

APPROVED, just fix up the desktop file.

Comment 3 Dominik 'Rathann' Mierzejewski 2010-12-06 23:43:52 UTC

Excellent! Big thanks for reviewing this. I promise I'll review a package by the end of the week.

New Package SCM Request
=======================
Package Name: wxmacmolplt
Short Description: A graphics program for plotting 3-D molecular structures and normal modes
Owners: rathann
Branches: f13 f14 el6
InitialCC:

Comment 4 Jens Petersen 2010-12-09 00:40:54 UTC

Git done (by process-git-requests).

Comment 5 Fedora Update System 2010-12-09 14:22:21 UTC

wxmacmolplt-7.4.1-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/wxmacmolplt-7.4.1-1.fc14

Comment 6 Fedora Update System 2010-12-09 14:22:29 UTC

wxmacmolplt-7.4.1-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/wxmacmolplt-7.4.1-1.fc13

Comment 7 Fedora Update System 2010-12-09 21:57:12 UTC

wxmacmolplt-7.4.1-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update wxmacmolplt'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/wxmacmolplt-7.4.1-1.fc13

Comment 8 Fedora Update System 2010-12-26 19:52:31 UTC

wxmacmolplt-7.4.1-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2010-12-26 19:53:54 UTC

wxmacmolplt-7.4.1-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.