Bug 544353

Summary: Successive actions to create "New Group Definition" contain dirty data fields (caught by automation)
Product: [Other] RHQ Project Reporter: John Sefler <jsefler>
Component: Resource GroupingAssignee: John Sanda <jsanda>
Status: CLOSED CURRENTRELEASE QA Contact: John Sefler <jsefler>
Severity: medium Docs Contact:
Priority: low    
Version: unspecifiedCC: smohan, whayutin
Target Milestone: ---Keywords: SubBug
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 2.4 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-08-12 16:51:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 562594, 565628, 584435    

Description John Sefler 2009-12-04 17:20:40 UTC 
Description of problem:
When creating a second "New Group Definition", the Name, Description, Recursive, and conditions fields are all pre-populated with the same values from the prior new group definition.

While this could be construed as an unintentional "feature", I believe it is a bug especially since the dirty Name field is not a valid value (has already been used) and that "New Group" does not behave this way.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. click Groups > New Group Definition 
2. enter Name, Description, Recursive, CREATE, select any template, Recalculation Interval, OK
3. click Groups > New Group Definition
BANG! the data fields are pre-filled and even after changing the Name and clicking CREATE, the conditions and recalculation interval are dirty too.
  
Actual results:
dirty data fields

Expected results:
empty data fields

Additional info:
This defect was detected by automated script DynagroupsTests.java
Comment 1 wes hayutin 2010-02-16 16:52:03 UTC 
Temporarily adding the keyword "SubBug" so we can be sure we have accounted for all the bugs.

keyword:
new = Tracking + FutureFeature + SubBug
Comment 2 wes hayutin 2010-02-16 16:58:00 UTC 
making sure we're not missing any bugs in rhq_triage
Comment 3 John Sanda 2010-04-21 18:59:00 UTC 
Pushed commit e4689aecd3198c18147bdcaf7b1e9c731752deaf to bugfixes branch.

There were two problems here. The ui bean code on the create and edit pages stores a marker attribute in the session to indicate that cached values should be used for form fields. The absence of the marker means that cached values should not be used. The ui beans for both pages were using the same marker, and if the group definition creation is successful, the marker should be getting removed from the session.

I have modified the code so that different markers are used and so that the marker is removed from the session if group definition creation is successful. This should resolve seeing the stale data.
Comment 4 John Sanda 2010-04-22 21:27:04 UTC 
Changes merged into master. Moving to ON_QA.
Comment 5 gneelaka@redhat.com 2010-04-23 08:17:14 UTC 
JON Build #108 Revision :10611

I have done the following steps:

1)click on groups ->new group definition.
2)enter the name,description,check the recursive check box.
3)Click on create.
4)Select a template and add recalculation interval in minutes.
5)click on ok .
6)click on group ->new group definitions.

observation : the name ,Description and Recursive fields are populated by predefined contents.

Steps :1)clear the contents in the name ,description and recursive.
2)add new contents name,description and check the recursive checkbox.
3)Click on create .

Observation : data in the template and the recalculation interval is predefined.

this is still not working on JON build.
Comment 6 John Sanda 2010-04-23 13:04:06 UTC 
If you look on hudson you will see that JON build 108 finished at Apr 21, 2010 4:35:00 PM. My changes were just merged into master yesterday, 4/22. There has not been a JON build that includes these changes. Moving back to ON_QA.
Comment 7 gneelaka@redhat.com 2010-04-27 09:56:43 UTC 
JON Build #112 Revision 10615

steps: 1)click on groups ->new group definition.
2)enter the name,description,check the recursive check box.
3)Click on create.
4)Select a template and add recalculation interval in minutes.
5)click on ok .
6)click on group ->new group definitions.

observation : the name and description fields are not predefined.When we try to create a new group definition with different name and description the group condition is preselected one and recalculation interval is also predefined.
Comment 8 John Sefler 2010-04-27 13:09:20 UTC 
This still fails for me as described in Comment #1
 RHQ
version: 3.0.0-SNAPSHOT
build number: 4fd30d0
Comment 9 John Sanda 2010-04-29 00:05:06 UTC 
Checked in a fix in the bugfixes branch that modifies the ui backing bean for the edit page so that stale values are not used to pre-populate form fields.

Commit hash - de211f8fc7cbee6258b7dde44a602e9734036b23
Comment 10 John Sanda 2010-04-29 00:08:25 UTC 
Commit de211f8fc7cbee6258b7dde44a602e9734036b23 has been merged into master. Moving to ON_QA.
Comment 11 gneelaka@redhat.com 2010-04-29 08:36:11 UTC 
JON Build #120 Revision:10615

steps: 1)click on groups ->new group definition.
2)enter the name,description,check the recursive check box.
3)Click on create.
4)Select a template and add recalculation interval in minutes.
5)click on ok .
6)click on group ->new group definitions.


Observation : the name and description fields are not predefined .the group condition and Recalculation intervals are also not predefined.

this is working fine now.
Comment 12 Corey Welton 2010-08-12 16:51:09 UTC 
Mass-closure of verified bugs against JON.