Bug 544739
| Summary: | Review Request: kopete-protocol-facebook - Facebook Protocol support for Kopete | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Magnus Tuominen <magnus.tuominen> |
| Component: | Package Review | Assignee: | Thomas Janssen <thomasj> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mail, notting, rdieter, thomasj |
| Target Milestone: | --- | Flags: | thomasj:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-20 17:49:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 539983 | ||
| Bug Blocks: | |||
|
Description
Magnus Tuominen
2009-12-06 09:55:34 UTC
forgot to submit rpmlint output: rpmlint -iv kopete-facebook-0.1.4-3.fc12.src.rpm kopete-facebook.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Depends on qjson, currently in review, bug ID 539983: https://bugzilla.redhat.com/show_bug.cgi?id=539983 rpmlint -iv kopete-facebook.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Made some changes to %build and %install and rebuilt with qjson from repositories using mock. rpmlint -iv kopete-facebook.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -iv kopete-facebook-0.1.4-4.fc12.src.rpm kopete-facebook.src: I: checking 1 packages and 0 specfiles checked; 0 errors, 0 warnings. http://rubbad.com/files/fedora/12/SPECS/kopete-facebook.spec http://rubbad.com/files/fedora/12/SRPM/kopete-facebook-0.1.4-4.fc12.src.rpm Removed redundant cmake from %install & %build rpmlint -iv kopete-facebook-*.rpm kopete-facebook.src: I: checking kopete-facebook.x86_64: I: checking kopete-facebook-debuginfo.x86_64: I: checking 3 packages and 0 specfiles checked; 0 errors, 0 warnings. http://rubbad.com/files/fedora/12/SPECS/kopete-facebook.spec http://rubbad.com/files/fedora/12/SRPM/kopete-facebook-0.1.4-5.fc12.src.rpm Version 0.1.5 upstream. No changes, same gitrev. kopete-facebook.src: I: checking kopete-facebook.x86_64: I: checking kopete-facebook-debuginfo.x86_64: I: checking 3 packages and 0 specfiles checked; 0 errors, 0 warnings. http://rubbad.com/files/fedora/12/SPECS/kopete-facebook.spec http://rubbad.com/files/fedora/12/SRPM/kopete-facebook-0.1.5-6.fc12.src.rpm Name change to upstream name: kopete-protocol-facebook Removed chrpath as it is no longer needed and added Author to description. rpmlint output: rpmlint -iv kopete-protocol-facebook-*.rpm kopete-protocol-facebook.src: I: checking kopete-protocol-facebook.x86_64: I: checking kopete-protocol-facebook-debuginfo.x86_64: I: checking 3 packages and 0 specfiles checked; 0 errors, 0 warnings. http://rubbad.com/files/fedora/12/SPECS/kopete-protocol-facebook.spec http://rubbad.com/files/fedora/12/SRPM/kopete-protocol-facebook-0.1.5-7.fc12.src.rpm rpmlint on spec file: rpmlint -iv kopete-protocol-facebook.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. Ok, i'm happy to do the pre-review. A new version, like here the change from 0.1.4 to 0.1.5 restarts the release with 1. Means you're currently at 0.1.5-2 Remove from changelog the fedora 12 betabuild entry. You missed to bump the release anyways and have two 0.1.4-1 Url should be: http://wiki.github.com/dmacvicar/kopete-facebook instead of http://kopete.kde.org/ The >= 4.2 for the kde BRs are redundant and can be removed. The BRs needed are: qjson-devel, kdenetwork-devel The rest is redundant and can be removed. You can remove the Provides and Obsoletes lines as well. Remove the redundant %post and %postun ldconfig lines. This is not a shlib, so not needed. In %files, use please kde4 macros as provided in: http://fedoraproject.org/wiki/SIGs/KDE#Best_Practices I will do a full review later. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers Hi, I've fixed the issues you mentioned. rpmlint -iv kopete-protocol-facebook-*.rpm kopete-protocol-facebook.src: I: checking kopete-protocol-facebook.x86_64: I: checking kopete-protocol-facebook-debuginfo.x86_64: I: checking 3 packages and 0 specfiles checked; 0 errors, 0 warnings. rpmlint -iv kopete-protocol-facebook.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. http://rubbad.com/files/fedora/12/SPECS/kopete-protocol-facebook.spec http://rubbad.com/files/fedora/12/SRPM/kopete-protocol-facebook-0.1.5-3.fc12.src.rpm OK# rpmlint must be run on every package.
[thomas@tusdell ~]$ rpmlint mock-test/kopete-protocol-facebook-0.1.5-3* mock-test/kopete-protocol-facebook-debuginfo-0.1.5-3.fc12.x86_64.rpm
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK# The package must be named according to the Package Naming Guidelines .
OK# The spec file name must match the base package %{name}
OK# The package must meet the Packaging Guidelines.
OK# The package must be licensed with a Fedora approved license and meet the Licensing Guidelines .
OK# The License field in the package spec file must match the actual license.
OK# License file included in %doc.
OK# The spec file must be written in American English.
OK# The spec file for the package MUST be legible.
OK# md5sum 2ff70b6a35587cb80729e37628af0342
OK# The package MUST successfully compile and build into binary rpms on at least one primary architecture.
OK# Compiles on all primary archs.
OK# Build dependencies listed in BuildRequires.
OK# Packages must NOT bundle copies of system libraries.
Issue# A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
Please add Requires: kdenetwork
OK# A Fedora package must not list a file more than once in the spec file's %files listings.
OK# Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line.
OK# %clean section, which contains rm -rf %{buildroot}
OK# Each package must consistently use macros.
OK# The package must contain code, or permissable content.
OK# doc handling
OK# No header files existent
OK# No static libraries existent
OK# No pkgconfig(.pc) files existent
OK# No need for a -devel subpackage
OK# No .la libtool archives existent
OK# No GUI application existent, so no desktop-file-install needed.
OK# Directory ownership
OK# At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK# All filenames in rpm packages must be valid UTF-8.
--
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers
Thank you for your review Thomas. Here's the new stuff rpmlint -iv kopete-protocol-facebook.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint -iv kopete-protocol-facebook-*.rpm kopete-protocol-facebook.src: I: checking kopete-protocol-facebook.x86_64: I: checking kopete-protocol-facebook-debuginfo.x86_64: I: checking 3 packages and 0 specfiles checked; 0 errors, 0 warnings. http://rubbad.com/files/fedora/12/SPECS/kopete-protocol-facebook.spec http://rubbad.com/files/fedora/12/SRPM/kopete-protocol-facebook-0.1.5-4.fc12.src.rpm *Approved* -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers New Package CVS Request ======================= Package Name: kopete-protocol-facebook Short Description: facebook protocol support for Kopete Owners: magnu5 Branches: F-11 F-12 InitialCC: thomasj CVS done (by process-cvs-requests.py). kopete-protocol-facebook-0.1.5-4.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/kopete-protocol-facebook-0.1.5-4.fc12 kopete-protocol-facebook-0.1.5-4.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/kopete-protocol-facebook-0.1.5-4.fc11 This is built and in rawhide/on the way into the repos. I think we can close it now. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers |