Bug 544821
| Summary: | Review Request: php-gettext - Gettext emulation in php | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | David Nalley <david> |
| Component: | Package Review | Assignee: | Felix Kaechele <felix> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eric, fedora-package-review, felix, nb, notting |
| Target Milestone: | --- | Flags: | felix:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.0.9-2.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-02-02 01:16:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 508817 | ||
|
Description
David Nalley
2009-12-06 16:56:42 UTC
Incorrect license specified: Spec URL: http://ke4qqq.fedorapeople.org/php-gettext.spec SRPM URL: http://ke4qqq.fedorapeople.org/php-gettext-1.0.9-2.fc12.src.rpm Fresh review from FUDCon Toronto Room A: [+] source files match upstream: [felix@delta SPECS]$ sha256sum php-gettext-1.0.9.tar.gz ../SOURCES/php-gettext-1.0.9.tar.gz b3aac9dd13971cabd2474cc93abfc665752f1f732646f4c911928b4323a70319 php-gettext-1.0.9.tar.gz b3aac9dd13971cabd2474cc93abfc665752f1f732646f4c911928b4323a70319 ../SOURCES/php-gettext-1.0.9.tar.gz [+] package meets naming and versioning guidelines. [+] spec is properly named, cleanly written, and uses macros consistently. [+] dist tag is present. [+] build root is correct. [+] license field matches the actual license. [+] license is open source-compatible. [+] license text included in package. [+] latest version is being packaged. [NA] BuildRequires are proper. [NA] compiler flags are appropriate. [+] %clean is present. [+] package builds in mock. [+] package installs properly. [NA] debuginfo package looks complete. [+] rpmlint is silent. [+] final provides and requires are sane [NA] %check is present and all tests pass: [+] no shared libraries are added to the regular linker search paths. [+] owns the directories it creates. [+] doesn't own any directories it shouldn't. [+] no duplicates in %files. [+] file permissions are appropriate. [NA] scriptlets match those on ScriptletSnippets page. [+] code, not content. [+] documentation is small, so no -docs subpackage is necessary. [+] %docs are not necessary for the proper functioning of the package. [+] no headers. [+] no pkgconfig files. [NA] no libtool .la droppings. [NA] desktop files valid and installed properly. APPROVED! Thanks for the review, Felix!!! New Package CVS Request ======================= Package Name: php-gettext Short Description: Gettext emulation in php Owners: ke4qqq Branches: F-11, F-12, EL-5 InitialCC: cvs done. php-gettext-1.0.9-2.el5 has been submitted as an update for Fedora EPEL 5. http://admin.fedoraproject.org/updates/php-gettext-1.0.9-2.el5 php-gettext-1.0.9-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-gettext-1.0.9-2.fc12 php-gettext-1.0.9-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-gettext-1.0.9-2.fc11 php-gettext-1.0.9-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-gettext'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-12876 php-gettext-1.0.9-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-gettext'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-12903 php-gettext-1.0.9-2.el5 has been pushed to the Fedora EPEL 5 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update php-gettext'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/EL-5/FEDORA-EPEL-2009-0984 php-gettext-1.0.9-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. php-gettext-1.0.9-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. php-gettext-1.0.11-1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/php-gettext-1.0.11-1.el5 |