Bug 545175

Summary:	[raw-config] Rollback fails on structured and raw server
Product:	[Other] RHQ Project	Reporter:	Preethi Thomas <pthomas>
Component:	Configuration	Assignee:	RHQ Project Maintainer <rhq-maint>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	low
Version:	unspecified	CC:	jsanda
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	2.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-08-12 16:59:40 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	538114

Description Preethi Thomas 2009-12-07 19:40:38 UTC

Description of problem:
Rollback fails on structured & raw server

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.Login to RHQ Server
2. navigate to the structured and raw server and go to configure tab
3.change the config value from the command prompt or from ui so that more than one revision is created
4. Navigate to Configuration ->History
5. Select an older revision to revert to
6. Click on Rollback button
  
Actual results:
Failed to rollback resource configuration to version 10145. Cause: org.rhq.enterprise.server.configuration.ConfigurationUpdateNotSupportedException:Cannot update a resource configuration that supports both structured and raw configuration using this method because there is insufficient information. You should instead call updateStructuredOrRawConfiguration() which requires you whether the structured or raw was updated.

Expected results:
Rollback successful.

Additional info:

Comment 1 John Sanda 2009-12-08 16:41:36 UTC

The error message with the ConfigurationUpdateNotSupportedException explains the issue. The older updateResourceConfiguration() method is being called, but it cannot be called for a configuration that supports both structured and raw. Instead, the new method, updateStructuredOrRawConfiguration() should be called since it takes a flag to indicate from which side (structured or raw) the update is happening.

Comment 2 John Sanda 2009-12-08 18:49:07 UTC

Committed fix for this. The hash is,

f43773789e7d9ec2826b951004c48d30afcfa571

Resource configuration rollback previously did not support configurations that support both structured and raw. Rollback for those configs is now implemented as an update from raw.

Comment 3 Preethi Thomas 2009-12-10 20:01:31 UTC

Rollback works on structured server & structured and raw server. raw server has some problems. will move to verified once I verify it on  raw only server.

Comment 4 Preethi Thomas 2009-12-15 19:28:18 UTC

Rollback is working in the latest raw-config branch.
moving to on_qa to test after merge.

Comment 5 Preethi Thomas 2010-01-07 14:31:26 UTC

verified in http://10.16.120.159:7080
rollback work in raw server, structured server , structured and raw server.

Comment 6 Corey Welton 2010-08-12 16:59:40 UTC

Mass-closure of verified bugs against JON.