Bug 545402

Event posted on 12-02-2009 11:16pm EST by agouny

Description of problem:
Using RHN Satellite 5.3 (x86_64) on RHEL 5.4 (x86_64), browsing the WebUI in 'Systems' -> 'Kickstart' -> 'Profiles' -> select or create a profile -> Go to 'Variables', 2 problems:
1: the Kickstart profile name is not displayed
2: trying to delete this kickstart from the same page fails

How reproducible:
always

Steps to Reproduce:

Actual results:
- No kickstart profile name displayed
- Failure on remove profile

Expected results:
- Kickstart profile name displayed
- Removal working like on other pages

Additional info:
This event sent from IssueTracker by vgaikwad  [Support Engineering Group]
 issue 372098

Event posted on 12-08-2009 08:35am EST by vgaikwad

Hello John,

Yes, the issue is reproducible and here's what I think:

The way
https://satellite.example.com/rhn/kickstart/EditVariables.do?ksid=121
renders is:

It calls
/var/lib/tomcat5/webapps/rhn/WEB-INF/pages/kickstart/kickstartvariables.jsp
which displays what we see on the WebUi when you click the above URL.
Looking at the JSP page I see that we have 2 ACLs that decides what to
display for 'Clone Kickstart' and 'Delete Kickstart'

<rhn:require acl="is_ks_raw(${ksid})"
mixins="com.redhat.rhn.common.security.acl.KickstartAclHandler">
        <%@ include
file="/WEB-INF/pages/common/fragments/kickstart/advanced/header.jspf"%>
 </rhn:require>
   
<rhn:require acl="is_ks_not_raw(${ksid})"
mixins="com.redhat.rhn.common.security.acl.KickstartAclHandler">
        <html:messages id="message" message="true">
                  <rhn:messages><c:out escapeXml="false"
value="${message}" /></rhn:messages>
                </html:messages>
        <%@ include
file="/WEB-INF/pages/common/fragments/kickstart/kickstart-toolbar.jspf"
%>

Basically, the acls are to check if the kickstart we are trying to
modify/access is created with the wizard ('Create Kickstart Profile') or
we have uploaded the kickstart file. So a RAW kickstart would be the
kickstart which has been uploaded and not created using the wizard.

In our case the kickstart was created using the wizard and it does
displays the correct kickstart header file but seems that the Kickstart ID
and the label is null.

I think the following change seems to have caused this issue:

http://git.fedorahosted.org/git/spacewalk.git?p=spacewalk.git;a=blobdiff;f=java/code/webapp/WEB-INF/pages/kickstart/kickstartvariables.jsp;h=e2653bfd780e138017e9e1d3acde73073b5de41c;hp=44acf6c58b84159d98e50d7237506990f3e26fda;hb=468392c0d43b3008ada0734cf925a2c18edb916e;hpb=3fe642bb771bf189eb5c897ae4180d21334495f9

We are now using ksid to refer to the kickstart ID where as the
kickstart-toolbar.jspf page has ksdata.id and ksdata.label.

spacewalk-java-0.5.44/code/webapp/WEB-INF/pages/common/fragments/kickstart/kickstart-toolbar.jspf

<%@ taglib uri="http://rhn.redhat.com/rhn" prefix="rhn" %>
<%@ taglib uri="http://jakarta.apache.org/struts/tags-bean"
prefix="bean" %>
<%@ taglib uri="http://java.sun.com/jsp/jstl/functions" prefix="fn"
%>
<rhn:toolbar base="h1" img="/img/rhn-kickstart_profile.gif" 
               imgAlt="system.common.kickstartAlt"
              
deletionUrl="/rhn/kickstart/KickstartDelete.do?ksid=${ksdata.id}"
               deletionType="kickstart"
              
cloneUrl="/rhn/kickstart/KickstartClone.do?ksid=${ksdata.id}"
               cloneType="kickstart">
  <bean:message key="kickstartdetails.jsp.header1"
arg0="${fn:escapeXml(ksdata.label)}"/>
</rhn:toolbar>

This is my best guess :)

Sending this to engineering as a bug.

regards,


This event sent from IssueTracker by vgaikwad  [Support Engineering Group]
 issue 372098

This was fixed in commit 8c398e9254180e361351ef729dec016155cf4a13 as part of bug 498009 for spacewalk.  Need to backport this.

Please be so kind and add a few key words to the Technical Notes of this
Bugzilla entry using the following structure:

Cause:

Consequence:

Fix:

Result:

For details, see:

https://bugzilla.redhat.com/page.cgi?id=fields.html#cf_release_notes

Thanks

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause:

Consequence:

Fix:

Result:

Verified:
RHEL4, REHL5- s390x, x86_64

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0189.html