Bug 545433
| Summary: | Review Request: shared-color-profiles - Shared color profiles for color management aware applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard Hughes <richard> |
| Component: | Package Review | Assignee: | Yanko Kaneti <yaneti> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, yaneti |
| Target Milestone: | --- | Flags: | yaneti:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2009-12-09 20:00:45 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Richard Hughes
2009-12-08 15:13:26 UTC
[hughsie@hughsie-work 12]$ rpmlint */shared-color-profiles* 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Seemed to build in koji just fine too: http://koji.fedoraproject.org/koji/taskinfo?taskID=1862719 Okay, here's a new spec, srpm and koji build. * I've added " and Public Domain" to the license tag * I've removed automake from the BR * I've updated the source tag to where it's going to live in reality * I've split the upstream repo into free and non-free, so it means the SRPM is not a few Kb in size, not Mb in size[1] Spec URL: http://people.freedesktop.org/~hughsient/temp/shared-color-profiles.spec SRPM URL: http://people.freedesktop.org/~hughsient/temp/shared-color-profiles-0.0.2-0.10.20091209git.src.rpm Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=1864001 Can you please review these new files -- thanks. Richard. [1] Debian was unable to ship the source file with the non-redistributable content, and insisted on two separate tarballs. I figured it was better for the mirrors (and possibly legally too) if the Fedora SRPM only contained the free files also. Looks good. I would do
@@ -26,16 +26,18 @@
%install
rm -rf $RPM_BUILD_ROOT
make install DESTDIR=$RPM_BUILD_ROOT
+mkdir Argyll
+mv $RPM_BUILD_ROOT/%{_datadir}/color/icc/Argyll/{README,LICENSE} Argyll/
%clean
rm -rf $RPM_BUILD_ROOT
%files
%defattr(-,root,root,-)
-%doc AUTHORS COPYING ChangeLog
+%doc AUTHORS COPYING ChangeLog Argyll
%dir %{_datadir}/color/icc
%dir %{_datadir}/color/icc/Argyll
-%{_datadir}/color/icc/Argyll/*
+%{_datadir}/color/icc/Argyll/*.icm
%{_datadir}/color/icc/*.icc
%changelog
but its up to you.
APPROVED
New Package CVS Request ======================= Package Name: shared-color-profiles Short Description: Shared color profiles for color management aware applications Owners: rhughes Branches: F-12 InitialCC: rhughes cvs done. Imported, thanks. |