Bug 545433

Summary: Review Request: shared-color-profiles - Shared color profiles for color management aware applications
Product: [Fedora] Fedora Reporter: Richard Hughes <richard>
Component: Package ReviewAssignee: Yanko Kaneti <yaneti>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting, yaneti
Target Milestone: ---Flags: yaneti: fedora‑review+
kevin: fedora‑cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2009-12-09 15:00:45 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Richard Hughes 2009-12-08 10:13:26 EST
Spec URL: http://people.freedesktop.org/~hughsient/temp/shared-color-profiles.spec
SRPM URL: http://people.freedesktop.org/~hughsient/temp/shared-color-profiles-0.0.1-0.8.20091208git.src.rpm
Description:

The shared-color-profiles package contains various profiles which are useful for
programs that are color management aware.
This package only contains the free profiles that can be safely distributed with Fedora.

*** BIG FAT LEGAL NOTE ***
The SRPM ships with a lot of ICC profiles that we cannot use in Fedora[1] and therefore I'm only installing the profiles found in ArgyllCMS which are in the public domain. Other profiles will be added to the Fedora package in the future only if they are free software, ack'd by redhat-legal. I expect the number of manufacturers to relicence their profiles to CC-BY-ND or CC-BY-SA to be small, but still significant.

The configure script defaults to only including the free profiles, not all of them. I guess someone could take the srpm and build it in rpmfusion with --enable-adobe --disable-argyll as shared-color-profiles-bad and it should coinstall nicely. This means that the noarch file is only a few kb in size, but the srpm is massive (13Mb). Worry not.

*** BIG FAT LEGAL NOTE ***

I want to make shared-color-profiles a hard dep on gnome-color-manager, as the next version will have UI that defaults to either the Adobe compatible gamut or the sRGB compatible gamut. This is required to make the UI feature compatible with what there is in OSX and Windows 7. The fact that the shared-color-profiles size is small also doesn't pose any issues if g-c-m is installed on the LiveCD by default.

As an aside, if we ever hear back from the official ICC guys and fedora-legal give us the okay, we can use the official ICC profile, rather than the public domain one. Until then we're shipping the latter as it's 99% the same thing.

[1] https://www.redhat.com/archives/fedora-legal-list/2009-December/msg00009.html
Comment 1 Richard Hughes 2009-12-08 10:14:31 EST
[hughsie@hughsie-work 12]$ rpmlint */shared-color-profiles*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

Seemed to build in koji just fine too: http://koji.fedoraproject.org/koji/taskinfo?taskID=1862719
Comment 2 Richard Hughes 2009-12-09 04:30:46 EST
Okay, here's a new spec, srpm and koji build.

* I've added " and Public Domain" to the license tag
* I've removed automake from the BR
* I've updated the source tag to where it's going to live in reality
* I've split the upstream repo into free and non-free, so it means the SRPM is not a few Kb in size, not Mb in size[1]

Spec URL: http://people.freedesktop.org/~hughsient/temp/shared-color-profiles.spec
SRPM URL: http://people.freedesktop.org/~hughsient/temp/shared-color-profiles-0.0.2-0.10.20091209git.src.rpm
Koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=1864001

Can you please review these new files -- thanks.

Richard.

[1] Debian was unable to ship the source file with the non-redistributable content, and insisted on two separate tarballs. I figured it was better for the mirrors (and possibly legally too) if the Fedora SRPM only contained the free files also.
Comment 3 Yanko Kaneti 2009-12-09 04:52:59 EST
Looks good. I would do 

@@ -26,16 +26,18 @@
 %install
 rm -rf $RPM_BUILD_ROOT
 make install DESTDIR=$RPM_BUILD_ROOT
+mkdir Argyll
+mv $RPM_BUILD_ROOT/%{_datadir}/color/icc/Argyll/{README,LICENSE} Argyll/
 
 %clean
 rm -rf $RPM_BUILD_ROOT
 
 %files
 %defattr(-,root,root,-)
-%doc AUTHORS COPYING ChangeLog
+%doc AUTHORS COPYING ChangeLog Argyll
 %dir %{_datadir}/color/icc
 %dir %{_datadir}/color/icc/Argyll
-%{_datadir}/color/icc/Argyll/*
+%{_datadir}/color/icc/Argyll/*.icm
 %{_datadir}/color/icc/*.icc
 
 %changelog


but its up to you.
APPROVED
Comment 4 Richard Hughes 2009-12-09 05:06:27 EST
New Package CVS Request
=======================
Package Name: shared-color-profiles
Short Description: Shared color profiles for color management aware applications
Owners: rhughes
Branches: F-12
InitialCC: rhughes
Comment 5 Kevin Fenzi 2009-12-09 12:51:35 EST
cvs done.
Comment 6 Richard Hughes 2009-12-09 15:00:45 EST
Imported, thanks.