Bug 547605
| Summary: | dnsmasq init.d script kills wrong dnsmasq processes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | James Ralston <ralston> | ||||||
| Component: | dnsmasq | Assignee: | Patrick Laughton <jima> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 12 | CC: | itamar, jima, markmc, nphilipp, veillard | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | 2.52-1.fc11 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2010-02-16 13:15:56 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
Ok, I see now that this was partially fixed in Rawhide (bug 512664), but not completely. I'll rework this patch against Rawhide's dnsmasq. (In reply to comment #1) ok, thanks. Ping? If you don't have the time, I can rework the above patch against Rawhide and build updated packages, just give me a shout. (In reply to comment #3) go ahead. Created attachment 383561 [details]
make sure init.d script condrestart() identifies correct dnsmasq process
Here's a reworked patch for the init.d script against current Rawhide.
fixed here. http://koji.fedoraproject.org/koji/buildinfo?buildID=153129 should I push an update for F-12 and F-11 ? dnsmasq-2.52-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/dnsmasq-2.52-1.fc12 > should I push an update for F-12 and F-11 ?
That'd be great.
dnsmasq-2.52-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/dnsmasq-2.52-1.fc11 dnsmasq-2.52-1.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update dnsmasq'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2010-1152 dnsmasq-2.52-1.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update dnsmasq'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2010-1160 dnsmasq-2.52-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. dnsmasq-2.52-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |
Created attachment 378428 [details] fix dnsmasq init.d script to not kill wrong dnsmasq processes If libvirt is installed, it runs a separate dnsmasq process: /usr/sbin/dnsmasq --strict-order --bind-interfaces --pid-file=/var/run/libvirt/network/default.pid --conf-file= --listen-address ... --except-interface lo --dhcp-range ...,... The dnsmasq init.d script does not use the proper init.d functions that are constrained to consider only dnsmasq processes specified in the pid file. As a result, a "service dnsmasq stop" will kill libvirt's dnsmasq process. The attached patch corrects the init.d script behavior. Please apply. Version: 0:dnsmasq-2.51-1.fc12.x86_64