Bug 547974

Some remarks:

* Won't build without intltool:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1878893

* BR: ibus-devel does not seem to be needed
  ( Well, it seems that %{_datadir}/ibus/component/
    or  /usr/share/skk seems hardcoded ?? )

* Please consider to use
---------------------------------------------------------
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"
---------------------------------------------------------
  to keep timestamps on installed files

! Well, I tried using ibus-skk, however
  - when I enable ibus/ibus-skk (on gedit or firefox or jd)
  - type "kannji"
  then each time I type "ka", "nn", "ji" each string is
  changed immediately to "か" "ん" then "じ", and no kanji
  conversion by space bar works... (well, my explanation
  may be not good... then:)

  geditやfirefox,jd上でibus/ibus-skkを有効にして試しに
  "kannji"とタイプすると、"ka","nn","ji"とタイプした瞬間に
　それぞれ"か""ん""じ"と直ぐに変換（確定）されてしまって、スペースを打って
　漢字の候補を選ぶことが全く出来ません

One more thing
- BuildArch should be noach.

> then each time I type "ka", "nn", "ji" each string is
> changed immediately to "か" "ん" then "じ", and no kanji
> conversion by space bar works...

That is expected behavior.  To start kana-kanji conversion in
SKK, you need to type first few letters in uppercase.  For the
above example, try "Kannji" or "KAnnji" instead of "kannji", and
then type space.

Anyway, thanks for packaging.  The resulted RPM was successfully
installed and seems to work fine here (on f12).

(In reply to comment #3)
> > then each time I type "ka", "nn", "ji" each string is
> > changed immediately to "か" "ん" then "じ", and no kanji
> > conversion by space bar works...
> 
> That is expected behavior.  To start kana-kanji conversion in
> SKK, you need to type first few letters in uppercase.  For the
> above example, try "Kannji" or "KAnnji" instead of "kannji", and
> then type space.

Ah, thank you for explanation.

Ueno-san, would you be interested in owning the package?
I only submitted because I made a test package...

Sure.  I will put the fixed package on the Web shortly.
(Perhaps I should make an upstream release before the package fix, since several minor bugs were fixed recently...)

(In reply to comment #6)
> Sure.  I will put the fixed package on the Web shortly.
> (Perhaps I should make an upstream release before the package fix, since
> several minor bugs were fixed recently...)  

Thank you. In such case, are you going to sponsor Ueno-san,
Petersen-san?

Sure if Ueno-san submits a package here happy to do that.

Sorry for being late.  I've just uploaded the spec file and SRPM to:
http://www.unixuser.org/~ueno/software/fedora/ibus-skk/ibus-skk.spec
http://www.unixuser.org/~ueno/software/fedora/ibus-skk/ibus-skk-0.0.4-1.fc12.src.rpm

Regards,

For 0.0.4-1:

* BR (BuildRequires)
  - Please check if "BR: gettext-devel" is really needed
    (I guess "BR: gettext" is sufficient)

* BuildArch
  - This package is noarch (i.e. add "BuildArch: noarch")

* %changelog
  - It is recommend to insert one line between each %changelog
    entry (as it is useful when using Fedora CVS) like:
--------------------------------------------------------------
%changelog
* Mon Jan 11 2010 Daiki Ueno <ueno> - 0.0.4-1
- current version

* Thu Dec 24 2009 Daiki Ueno <ueno> - 0.0.2-1
- new upstream release

* Fri Dec 11 2009 Jens Petersen <petersen> - 0.0.1-1
- initial packaging for fedora
--------------------------------------------------------------

Thanks for the review.  I've just put the fixed files on the same URL.

For "BR: gettext-devel", it seems that "BR: intltool" (already there) is sufficient since intltool requires gettext-devel.

Please change the release number every time you modify
your spec file to avoid confusion (and add %changelog
entry appropriately)

Done, thanks.

Looks okay to me. Now when Petersen-san sponsors Ueno-san, I
will approve this package.

What is the status of this bug?

Ueno-san: sorry for sitting on this - my apologies.

http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Are you able to do at least one package pre-review
of someone's submitted package or to submit another package for review?

Sorry but this is normally asked of new fedora packagers
to become familiar with the fedora review process, since
they can review and approve other package submissions.

ping?

ping again?

To clarify the current status:
-------------------------------------------------------------
NOTE: Before being sponsored:

This package will be accepted with another few (or no) work. 
But before I accept this package, someone (I am a candidate) 
must sponsor you.

Once you are sponsored, you have the right to review other 
submitters' review requests and approve the packages formally. 
For this reason, the person who want to be sponsored (like you) 
are required to "show that you have an understanding 
of the process and of the packaging guidelines" as is described
on :
http://fedoraproject.org/wiki/PackageMaintainers/HowToGetSponsored

Usually there are two ways to show this.
A. submit other review requests with enough quality.
B. Do a "pre-review" of other person's review request
   (at the time you are not sponsored, you cannot do
   a formal review)

When you have submitted a new review request or have pre-reviewed other 
person's review request, please write the bug number on this bug report 
so that I can check your comments or review request.

Fedora package collection review requests which are waiting for someone to
review can be checked on my wiki page:
http://fedoraproject.org/wiki/User:Mtasaka#B._Review_request_tickets
(Check "No one is reviewing")

Review guidelines are described mainly on:
http://fedoraproject.org/wiki/Packaging/ReviewGuidelines
http://fedoraproject.org/wiki/Packaging/Guidelines
http://fedoraproject.org/wiki/Packaging/ScriptletSnippets
------------------------------------------------------------

Sorry for late response.  I'll certainly follow the convention to become a fedora packager.

I had wondered which package I can work on - currently I'm thinking of packaging cocot, a terminfo-aware code conversion program:
http://vmi.jp/software/cygwin/cocot.html

Anyway, thanks for the detail information.  I'll soon update the current status.

(In reply to comment #19)
> I had wondered which package I can work on - currently I'm thinking of
> packaging cocot, a terminfo-aware code conversion program:
> http://vmi.jp/software/cygwin/cocot.html

No problem. When you submit a review request for this, please let
us know on this bug.

I've just posted a couple of review requests.  One is for Cocot (Bug#567052), and another is for the Uzbl web browser (Bug#567053).

Well, now I approve this package.

----------------------------------------------------------
  This package (ibus-skk) is APPROVED by mtasaka
----------------------------------------------------------

Please follow the procedure written on:
http://fedoraproject.org/wiki/PackageMaintainers/Join
from "Get a Fedora Account".
After you request for sponsorship a mail will be sent to sponsor 
members automatically (which is invisible for you) which notifies 
that you need a sponsor. After that, please also write on
this bug for confirmation that you requested for sponsorship and
your FAS (Fedora Account System) name. Then I will sponsor you.

If you want to import this package into Fedora 11/12/13, you also have
to look at
http://fedoraproject.org/wiki/Infrastructure/UpdatesSystem/Bodhi-info-DRAFT
(after once you rebuilt this package on koji Fedora rebuilding system).

If you have questions, please ask me.

Petersen-san, thank you for your help.

Ueno-san, would you create your account on FAS and request for
sponsorship?

Tasaka-san, sorry for bothering you again.  I created my account "ueno" on FAS, but I couldn't figure out how to "request for sponsorship" on the system.  Is that triggered by applying to some group?  (while I see "Please do not apply to this group" in the "packagers" group description)

Now I am sponsoring you. Please follow "Join" wiki again.

New Package CVS Request
=======================
Package Name: ibus-skk
Short Description: Japanese SKK input method for ibus
Owners: ueno
Branches: F-13 F-12 F-11

CVS done (by process-cvs-requests.py).

For F-11/12/13, please visit bodhi and submit push requests there.

ibus-skk-0.0.4-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/ibus-skk-0.0.4-2.fc13

ibus-skk-0.0.4-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/ibus-skk-0.0.4-2.fc12

ibus-skk-0.0.4-2.fc11 has been submitted as an update for Fedora 11.
http://admin.fedoraproject.org/updates/ibus-skk-0.0.4-2.fc11

Closing.

ibus-skk-0.0.4-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

ibus-skk-0.0.4-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

ibus-skk-0.0.4-2.fc11 has been pushed to the Fedora 11 stable repository.  If problems still persist, please make note of it in this bug report.