Bug 548482
| Summary: | Review Request: gnome-dvb-daemon - Digital Television manager | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bastien Nocera <bnocera> |
| Component: | Package Review | Assignee: | Matthias Clasen <mclasen> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mclasen, notting |
| Target Milestone: | --- | Flags: | mclasen:
fedora-review+
j: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-03-03 11:32:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 532470 | ||
| Bug Blocks: | 507681 | ||
|
Description
Bastien Nocera
2009-12-17 15:44:22 UTC
Dumb question - does it make sense to split off the totem plugin such that you'd be running the daemon on some server box, and the totem plugin on other machines on your network? (In reply to comment #1) > Dumb question - does it make sense to split off the totem plugin such that > you'd be running the daemon on some server box, and the totem plugin on other > machines on your network? The Totem plugin doesn't hard-require Totem, so it's just a couple of python files on your computer... Updated: http://people.fedoraproject.org/~hadess/gnome-dvb-daemon/gnome-dvb-daemon.spec http://people.fedoraproject.org/~hadess/gnome-dvb-daemon/gnome-dvb-daemon-0.1.14-1.fc12.src.rpm Updated: http://people.fedoraproject.org/~hadess/gnome-dvb-daemon/gnome-dvb-daemon.spec http://people.fedoraproject.org/~hadess/gnome-dvb-daemon/gnome-dvb-daemon-0.1.14-2.fc12.src.rpm Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=1956880 Adding to F13 blockers, otherwise Totem will regress and lose DVB support. Builds fine in mock rpmlint results: $ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/gnome-dvb-daemon-0.1.14-2.fc14.*.rpm gnome-dvb-daemon.src: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging gnome-dvb-daemon.src: W: spelling-error %description -l en_US Rygel -> Rigel, Ry gel, Ry-gel gnome-dvb-daemon.x86_64: W: spelling-error %description -l en_US plugin -> plug in, plug-in, plugging gnome-dvb-daemon.x86_64: W: spelling-error %description -l en_US Rygel -> Rigel, Ry gel, Ry-gel gnome-dvb-daemon.x86_64: E: non-executable-script /usr/lib/python2.6/site-packages/gnomedvb/DBusWrapper.py 0644L /usr/bin/env 2 packages and 0 specfiles checked; 1 errors, 4 warnings. The spelling warnings are laughable, but the permissions should probably be fixed. While doing so, you probably also want to nuke /usr/bin/env there, since I believe our policy is to use system python. package name: ok spec file name: ok packaging guidelines: ok, could maybe loose the BuildRoot (since rpmbuild handles that itself nowadays) license: ok license field: seems wrong, COPYING is GPLv3, but you say LGPLv3+ license file: ok spec file language: ok spec file readable: ok upstream sources: ok buildable: ok ExcludeArch: ok BuildRequires: ok locale handling: ok ldconfig: ok system libraries: ok relocatable: no, ok directory ownership: need to add a totem dep for /usr/lib/totem/plugins duplicate files: ok file permissions: see above %clean: ok macro use: ok content: permissible large docs: none, ok %doc content: ok headers: ok static libs: ok pc files: ok shared libs: ok devel deps: ok libtool archives: ok gui apps: ok directory ownership: ok %install: ok utf8 filenames: ok The python scripts aren't really scripts. They're python modules. The env bits are used when running the program by itself (usually running the self-test for that part of the module). It shouldn't be executable in its installed form. Fixed the buildroot, and license. Will leave the plugins directory, as I'd rather totem wasn't a requirement for gnome-dvb-daemon. Totem would require gnome-dvb-daemon, but not vice-versa (as gnome-dvb-daemon can be used by other apps). http://people.fedoraproject.org/~hadess/gnome-dvb-daemon/gnome-dvb-daemon.spec http://people.fedoraproject.org/~hadess/gnome-dvb-daemon/gnome-dvb-daemon-0.1.14-3.fc12.src.rpm > Will leave the plugins directory, as I'd
> rather totem wasn't a requirement for gnome-dvb-daemon. Totem would require
> gnome-dvb-daemon, but not vice-versa
Well, in that case, you need to own the directories, I think.
(In reply to comment #9) > > Will leave the plugins directory, as I'd > > rather totem wasn't a requirement for gnome-dvb-daemon. Totem would require > > gnome-dvb-daemon, but not vice-versa > > Well, in that case, you need to own the directories, I think. "you" being? I don't want peopel to have to install Totem to be able to install gnome-dvb-daemon. Can 2 packages own the same directories? Yes, that is what I meant: have both packages own the directories Done in: http://people.fedoraproject.org/~hadess/gnome-dvb-daemon/gnome-dvb-daemon-0.1.14-4.fc12.src.rpm http://people.fedoraproject.org/~hadess/gnome-dvb-daemon/gnome-dvb-daemon.spec approved New Package CVS Request ======================= Package Name: gnome-dvb-daemon Short Description: Digital Television manager Owners: hadess Branches: F-12 F-13 InitialCC: CVS done (by process-cvs-requests.py). Pushed to F-13 and rawhide. The F-12 build will wait until gstreamer-plugins-bad-free becomes available outside the updates. |