Bug 548634

Description of problem:
A basic requirement to improve password quality is to be able to use non-alphanumeric characters, like '#' in a password. The parsing of /etc/rhn/rhn.conf cannot handle such characters, for example if the rhnsat user's database password is changed to :

myReal#secure

The database itself handles that just fine. The python code that parses the default_db config file entry in /etc/rhn/rhn.con like so:

default_db = rhnsat/myReal#secure@rhnsat

does not handle the # character. The other places here a DB password is defined also do not have the # character handled properly

Version-Release number of selected component (if applicable):
None

How reproducible:
100%

Steps to Reproduce:
1. Install rhn Satellite 
2. Verify it is working


3. Stop the rhn-satellite
# rhn-satellite stop


4. Become oracle user, and make sure the DB is stopped:

# su - oracle -s /bin/bash
-bash-3.2$ db-control status
The database is offline.



5. Start the DB instance:
-bash-3.2$ db-control start
Starting database... done.



6. Connect to the oracle DB system:

-bash-3.2$ ORACLE_SID=rhnsat sqlplus system/rhnsat
..,
SQL>

7. Change the password for the rhnsat user:

SQL> alter user rhnsat identified by "rhnMySatellite3##wingnut" account unlock;

User altered.

SQL> quit
...,


7. Test connection using new password:

-bash-3.2$ sqlplus rhnsat/rhnMySatellite3##wingnut@rhnsat

...,
SQL> quit
...,


8. Stop the DB:

-bash-3.2$ db-control stop
Shutting down database... done.




9. Now edit the DB password in several places:

/etc/rhn/rhn.conf:default_db = rhnsat/rhnsat@rhnsat
/etc/rhn/rhn.conf:hibernate.connection.password=rhnsat
/etc/rhn/cluster.ini:LocalConfig.0.password=rhnsat

For example my new password is "rhnMySatellite3##wingnut" and I need to quote it now
because it has the # character in it:


/etc/rhn/rhn.conf:default_db = rhnsat/rhnMySatellite3##wingnut@rhnsat
/etc/rhn/rhn.conf:hibernate.connection.password=rhnMySatellite3##wingnut
/etc/rhn/cluster.ini:LocalConfig.0.password=rhnMySatellite3##wingnut


10. Start the Satellite 
  
Actual results:
Several services that need to connect to the Orace DB instance fail, and the rhnsat user is locked. The Satellite is non-functional.

Expected results:
Should be able to use # characters in passwords for the Oracle DB

Additional info:
I propose that we allow quotes around variables in /etc/rhn/rhn.conf, and change the rhnConf.py file parse_line function so it handles quotes, and thus allows # characters.