Bug 548756

Summary:	extend interface so JobCancel can take second parameter
Product:	[Fedora] Fedora	Reporter:	Jiri Popelka <jpopelka>
Component:	cups-pk-helper	Assignee:	Marek Kašík <mkasik>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	13	CC:	mkasik, twaugh
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	cups-pk-helper-0.0.4-13.fc13	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-04-16 23:29:34 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	576496

Description Jiri Popelka 2009-12-18 14:18:26 UTC

Description of problem:
In PyCUPS I've changed the Connection.cancelJob() function to take one optional int parameter indicating whether job files (history and document) are purged.
I'd like to change the cups-pk-helper D-Bus API JobCancel method or create another JobCancel2 or JobPurge or other method so I can use PolicyKit to call Connection.cancelJob with two parameters.

I'm PolicyKit beginner so I leave it up to you, what's best.

On 12/18/2009 01:04 PM, Tim Waugh wrote:
The problem is that the cups-pk-helper D-Bus API defines the JobCancel
method as only taking one parameter.  Unfortunately D-Bus doesn't have a
built-in concept of optional parameters, so changing that method to take
two parameters instead of one will break the interface.
The solution is either to extend the existing interface (either by
adding a JobCancel2 method taking an extra parameter, or by adding a new
JobPurge method), or to add a new interface e.g.
org.opensuse.CupsPkHelper.Mechanism2 which defines all the same methods
as before but has two parameters instead of one for JobCancel.

Additional info:
http://www.cups.org/documentation.php/doc-1.4/spec-ipp.html#CANCEL_JOB

Comment 1 Bug Zapper 2010-03-15 13:37:06 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 13 development cycle.
Changing version to '13'.

More information and reason for this action is here:
http://fedoraproject.org/wiki/BugZappers/HouseKeeping

Comment 2 Fedora Update System 2010-03-22 15:33:49 UTC

cups-pk-helper-0.0.4-13.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/cups-pk-helper-0.0.4-13.fc13

Comment 3 Marek Kašík 2010-03-22 16:07:42 UTC

Added new method JobCancelPurge, which takes one more parameter in comparison to JobCancel. The parameter is boolean 'purge'. It controls whether the job files are purged.

Marek

Comment 4 Fedora Update System 2010-03-23 23:25:56 UTC

cups-pk-helper-0.0.4-13.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update cups-pk-helper'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/cups-pk-helper-0.0.4-13.fc13

Comment 5 Fedora Update System 2010-04-16 23:29:28 UTC

cups-pk-helper-0.0.4-13.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.