Bug 549198
| Summary: | Review Request: python-jabberbot - A simple jabber (XMPP) bot framework | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Thomas Spura <tomspur> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | a.badger, fedora-package-review, notting, tomspur |
| Target Milestone: | --- | Flags: | tomspur:
fedora-review+
a.badger: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 0.8-2.fc11 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-02 03:28:02 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2009-12-20 21:37:48 UTC
Review:
Good:
- name ok
- %files section ok
- permissions ok
- rpmlint clean
- macros everywhere
- %clean is there
- %doc ok
- no *.la files
- no libs
- no gui -> no desktop file
- no translations
- group ok
Needswork:
- Have you queried upstream to include a COPYING file?
If not yet, please do so.
- BR: python-devel is not needed
- --prefix=%{_prefix} is not needed in %install
- License is GPLv3+ not GPLv3 only
#######################
These are only minor issues, which are fixed easily -> appoving
#######################
APPROVED
Thanks for the review Thomas. (In reply to comment #1) > Needswork: > - Have you queried upstream to include a COPYING file? > If not yet, please do so. I'm waiting for an answer from upstream about that issue. > - BR: python-devel is not needed The Guidelines says 'python-devel' must be added because it's no longer in the default package set. Am I wrong? http://fedoraproject.org/wiki/Packaging:Python > - --prefix=%{_prefix} is not needed in %install Will be removed > - License is GPLv3+ not GPLv3 only Will be fixed New Package CVS Request ======================= Package Name: python-jabberbot Short Description: A simple jabber (XMPP) bot framework Owners: fab Branches: F-11 F-12 InitialCC: python-devel is needed to build python packages. I'm remember precisely what the issue with that was, however, so it's possible that the python package in Fedora-13 has fixed this (dmalcolm fixed one issue with python-devel being needed in F-13's package). Fedora 12 and below still need it to build, though. cvs done. python-jabberbot-0.8-2.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/python-jabberbot-0.8-2.fc12 python-jabberbot-0.8-2.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/python-jabberbot-0.8-2.fc11 python-jabberbot-0.8-2.fc12 has been pushed to the Fedora 12 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-jabberbot'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F12/FEDORA-2009-13620 python-jabberbot-0.8-2.fc11 has been pushed to the Fedora 11 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-jabberbot'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F11/FEDORA-2009-13674 python-jabberbot-0.8-2.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. python-jabberbot-0.8-2.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. |