Bug 549605

Summary: Review Request: libopenr2 - MFC/R2 call setup library
Product: [Fedora] Fedora Reporter: Itamar Reis Peixoto <itamar>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-12-17 10:27:21 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
Bug Depends On:    
Bug Blocks: 201449    

Description Itamar Reis Peixoto 2009-12-21 22:28:53 EST
Spec URL: http://itamarjp.fedorapeople.org/libopenr2/libopenr2.spec
SRPM URL: http://itamarjp.fedorapeople.org/libopenr2/libopenr2-1.2.0-1.fc13.src.rpm
Description: 

OpenR2 is a library that implements the MFC/R2 signalling over E1 lines using
the Zapata Telephony interface. The MF R2 tones required for the signalling are
generated by code borrowed from the LGPL library SpanDSP written by Steve
Underwood, the user has the option to provide a MF interface to use his own
MF R2 tone generation and detection so the library will use them when needed,
that's why this library does not depend directly on spandsp, libteletone or
zaptel for tone generation and detection
(depends on zaptel for ABCD bits and general media transmission though)



E1 with r2 signalling is used in brazil and mexico.



http://koji.fedoraproject.org/koji/taskinfo?taskID=1885261
Comment 1 Michael Schwendt 2010-01-11 15:03:01 EST
> %files
> %doc %dir doc/asterisk

Directories are never marked %doc.

> %config(noreplace) %{_sysconfdir}/openr2/r2proto.conf
> %config(noreplace) %{_sysconfdir}/openr2/r2test.conf

Which package owns %{_sysconfdir}/openr2/?

> %files devel
> %doc AUTHORS ChangeLog COPYING COPYING.LESSER NEWS README TODO

Is it really necessary to duplicate all these %doc files in this package? The -devel package already depends on the base package anyway.

> %{_includedir}/openr2.h
> %{_includedir}/openr2/*.h

Directory %{_includedir}/openr2/ is not included.


> License:        LGPLv2
> %doc AUTHORS ChangeLog COPYING COPYING.LESSER NEWS README TODO

Interestingly, files COPYING and COPYING.LESSER contain the GPL v3 and the LGPL v3, respectively. And many of the source files contain either a LGPLv2 or LGPLv2+ header, so the licensing is not clear yet.
Comment 2 Jason Tibbitts 2010-11-14 13:48:12 EST
Were the licensing issues ever clarified?  How about some response to the above commentary?