Bug 549666

Summary: Link to /network/keys/key_list.pxt in Proxy installer
Product: [Community] Spacewalk Reporter: Jan Pazdziora (Red Hat) <jpazdziora>
Component: Proxy ServerAssignee: Jan Pazdziora (Red Hat) <jpazdziora>
Status: CLOSED CURRENTRELEASE QA Contact: Red Hat Satellite QA List <satqe-list>
Severity: medium Docs Contact:
Priority: low    
Version: 0.7   
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-02-16 12:56:02 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 543511    

Description Jan Pazdziora (Red Hat) 2009-12-22 10:18:04 UTC
Description of problem:

In web/html/applications/rhn-proxy/5.3/install-rhn-proxy.xml and other install-rhn-proxy.xml files, there is section

    <collect-data description="Configure SSL" acl="not global_config(satellite)">
      <header>
        In order to configure SSL on your ${app.name}, you will need
        to generate a CA certificate and an SSL key pair.  See the
        <a href="/rhn/help/proxy/rhn530/en-US/s1-installation-install-config.jsp">RHN Proxy
        Installation Guide </a> for more details.  After you have
        generated the SSL key, you will need to upload the resulting
        tar file containing the certificate files using the form
        below.  If the SSL CA certificate included in the tar file does
        not already exist in your org's <a
        href="/network/keys/key_list.pxt" target="_new">list of SSL
        keys</a>, it will be added to that list.
      </header>

there. This seems to be the only reference to /network/keys/key_list.pxt in Spacewalk, and /rhn/keys/CryptoKeysList.do probably should be used instead.

Now, I was not able to quickly figure out in which case the ACL

   acl="not global_config(satellite)"

matches -- is it only for hosted? If yes, this section could probably be dropped completely (and we could use full audit of the "not global_config(satellite)" in our code), and in that case rhn:edit_ckey_cb could be dropped as well.

Version-Release number of selected component (if applicable):

Spacewalk 0.7 source code.

How reproducible:

Deterministic -- looking to the code.

Steps to Reproduce:
1. git grep /network/keys
  
Actual results:

web/html/applications/rhn-proxy/4.0/install-rhn-proxy.xml:        href="/network/keys/key_list.pxt" target="_new">list of SSL
web/html/applications/rhn-proxy/4.1/install-rhn-proxy.xml:        href="/network/keys/key_list.pxt" target="_new">list of SSL
web/html/applications/rhn-proxy/4.2/install-rhn-proxy.xml:        href="/network/keys/key_list.pxt" target="_new">list of SSL
web/html/applications/rhn-proxy/5.0/install-rhn-proxy.xml:        href="/network/keys/key_list.pxt" target="_new">list of SSL
web/html/applications/rhn-proxy/5.1/install-rhn-proxy.xml:        href="/network/keys/key_list.pxt" target="_new">list of SSL
web/html/applications/rhn-proxy/5.2/install-rhn-proxy.xml:        href="/network/keys/key_list.pxt" target="_new">list of SSL
web/html/applications/rhn-proxy/5.3/install-rhn-proxy.xml:        href="/network/keys/key_list.pxt" target="_new">list of SSL
web/modules/sniglets/Sniglets/CryptoKey.pm:     $pxt->redirect("/network/keys/edit.pxt?ckid=" .$pxt->param('ckid'));
web/modules/sniglets/Sniglets/CryptoKey.pm:     $pxt->redirect("/network/keys/edit.pxt");

Expected results:

Nothing in web/html/applications, probably.

Additional info:

Comment 1 Jan Pazdziora (Red Hat) 2010-02-02 11:04:54 UTC
Taking.

Comment 2 Jan Pazdziora (Red Hat) 2010-02-02 11:10:13 UTC
Link fixed in Spacewalk master ca806caf0604a92a72a69c6c6c78d230ae876a53.

Comment 3 Jan Pazdziora (Red Hat) 2010-02-02 12:57:18 UTC
Tagged and built spacewalk-web-0.8.13-1.*, they will show up in the nightly repos.

Comment 4 Michael Mráka 2010-02-16 12:58:59 UTC
Spacewalk 0.8 has been released