Bug 550598
| Summary: | Review Request: themonospot-plugin-mkv - manage Matroska container | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Armando Basile <hmandevteam> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, mtasaka, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://www.integrazioneweb.com/themonospot/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-11 14:56:27 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 550594 | ||
| Bug Blocks: | 550519 | ||
|
Description
Armando Basile
2009-12-26 09:03:28 UTC
SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-plugin-mkv.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-plugin-mkv-0.1.0-2.fc12.src.rpm changes: - added BuildRequires: themonospot-base-devel - removed min. release req. for mono-core and themonospot-base - added copying.gpl First of all, as far as I read Fedora guidelines related to Mono, this package contradicts with it. https://fedoraproject.org/wiki/Packaging/Mono ==== # Assembly: An assembly is the EXE or DLL file created by compiling a mono application. These are not the same as EXE's or DLL's created by compiling a C or C++ program on Windows. An assembly contains CIL code rather than machine code. Mono packages should install assemblies to %{_libdir} rather than /usr/lib or %{_datadir}. In most cases the preference is for %{_libdir}/PACKAGENAME. We use %{_libdir} because we do not consider mono packages to be noarch. ==== Also it seems that this package installs pre-compiled .dll file shipped in the tarball. SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-plugin-mkv.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-plugin-mkv-0.1.1-1.fc12.src.rpm changes: - added copying.gpl - folder moved to %{_libdir}/themonospot/plugins/%{name} SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-plugin-mkv.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-plugin-mkv-0.1.1-2.fc12.src.rpm changes: - only mono-devel as BuildRequire SPEC URL: http://www.integrazioneweb.com/repository/SPECS/fedora/themonospot-plugin-mkv.spec SRPM URL: http://www.integrazioneweb.com/repository/SRPMS/fedora/themonospot-plugin-mkv-0.1.1-3.fc12.src.rpm changes: - added themonospot-base-devel as BuildRequire Now
- this package is correctly built from source
- install directory proper
- other things okay
-------------------------------------------------------------------
This package (themonospot-plugin-mkv) is APPROVED by mtasaka
-------------------------------------------------------------------
New Package CVS Request ======================= Package Name: themonospot-plugin-mkv Short Description: Matroska plugin for Themonospot suite Owners: hman Branches: F-11 F-12 InitialCC: mtasaka.u-tokyo.ac.jp Cvsextras Commits: yes New Package CVS Request ======================= Package Name: themonospot-plugin-mkv Short Description: Matroska plugin for Themonospot suite Owners: hman-it Branches: F-11 F-12 InitialCC: mtasaka Cvsextras Commits: yes cvs done. Closing. |