Bug 551940
| Summary: | Review Request: php-symfony-YAML - The Symfony YAML Component | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Remi Collet <fedora> |
| Component: | Package Review | Assignee: | Christof Damian <christof> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | christof, fedora-package-review, notting |
| Target Milestone: | --- | Flags: | christof:
fedora-review+
dennis: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.0.2-1.fc12 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-01-22 22:35:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 555986 | ||
|
Description
Remi Collet
2010-01-03 08:14:06 UTC
MUST:
OK: rpmlint must be run on every package.
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
OK: The package must be named according to the Package Naming Guidelines
OK: The spec file name must match the base package %{name}
OK: The package must meet the Packaging Guidelines
OK: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines
OK: The License field in the package spec file must match the actual license.
OK: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
OK: The spec file must be written in American English.
OK: The spec file for the package MUST be legible.
OK: The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use md5sum for this task. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
OK: The package MUST successfully compile and build into binary rpms on at least one primary architecture.
OK: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. Apply common sense.
OK: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
OK: A Fedora package must not list a file more than once in the spec file's %files listings.
OK: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line.
OK: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK: Each package must consistently use macros.
OK: The package must contain code, or permissable content.
OK: If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
OK: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT).
OK: All filenames in rpm packages must be valid UTF-8.
SHOULD:
OK: The reviewer should test that the package builds in mock.
OK: The reviewer should test that the package functions as described. A package should not segfault instead of running, for example.
APPROVED.
Thanks for the Review. New Package CVS Request ======================= Package Name: php-symfony-YAML Short Description: The Symfony YAML Component Owners: remi Branches: F-12 F-11 InitialCC: CVS done (by process-cvs-requests.py). php-symfony-YAML-1.0.2-1.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/php-symfony-YAML-1.0.2-1.fc12 php-symfony-YAML-1.0.2-1.fc11 has been submitted as an update for Fedora 11. http://admin.fedoraproject.org/updates/php-symfony-YAML-1.0.2-1.fc11 php-symfony-YAML-1.0.2-1.fc11 has been pushed to the Fedora 11 stable repository. If problems still persist, please make note of it in this bug report. php-symfony-YAML-1.0.2-1.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: php-symfony-YAML New Branches: EL-6 Owners: remi CVS Done |