Bug 552554
Summary: | Merge Review: perl-Convert-BinHex - Macintosh BinHex extractor library for Perl | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Marcela Mašláňová <mmaslano> |
Component: | Package Review | Assignee: | Jan Vcelak <jvcelak> |
Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | rawhide | CC: | fedora-package-review, jvcelak, notting, paul, perl-devel, tsmetana |
Target Milestone: | --- | Flags: | jvcelak:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-01-22 11:21:55 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Marcela Mašláňová
2010-01-05 14:24:03 UTC
MUST items: [YES] rpmlint is silent: $ rpmlint ./perl-Convert-BinHex.spec perl-Convert-BinHex-1.119-11.fc13.noarch.rpm perl-Convert-BinHex-1.119-11.fc13.src.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. [YES] Package meets naming and packaging guidelines. [YES] Spec file matches the base package name. [NOT SURE] Meets licensing guidelines. [NO] License specified in spec file and matches. - CPAN says: Unknown license - included COPYING contains text of GPLv1 - spec file says: GPL+ or Artistic [YES] Spec file in American English. [YES] Spec file is legible. [NO] Spec file uses macros consistently. - %install section contains /usr/bin/find %{buildroot} -type f -name .packlist -exec rm -f {} ';' while few lines above macro %{__rm} is used - %{__chmod} -R u+w %{buildroot}/* might be replaced with %{_fixperms} %{buildroot}/* [YES] Sources match upstream version. [YES] Can be successfully compiled. [YES] All BuildRequires are listed. [YES] Doesn't bundle copies of system libraries. [YES] Owns all it's files. [YES] Directory ownership meets Perl packaging guidelines. [YES] Permissions specified properly in %files. [YES] Contains code, or permissible content. [YES] Documentation needn't separate package. [YES] %doc files doesn't affect runtime. [YES] Cleans buildroot in %clean. [YES] Cleans buildroot at the beginning of %install. [YES] All filenames are valid UTF-8. Other must items doesn't concern. SHOULD items: [YES] Builds in mock. [YES] Builds on all supported architectures. (Package is architecture independent.) [YES] Sane scriptlets. (In reply to comment #1) > MUST items: > > [YES] rpmlint is silent: > > $ rpmlint ./perl-Convert-BinHex.spec > perl-Convert-BinHex-1.119-11.fc13.noarch.rpm > perl-Convert-BinHex-1.119-11.fc13.src.rpm > 2 packages and 1 specfiles checked; 0 errors, 0 warnings. > > [YES] Package meets naming and packaging guidelines. > [YES] Spec file matches the base package name. > > [NOT SURE] Meets licensing guidelines. > [NO] License specified in spec file and matches. > - CPAN says: Unknown license > - included COPYING contains text of GPLv1 > - spec file says: GPL+ or Artistic lib/Convert/BinHex.pm (the actual code) says (near the end): Copyright (c) 1997 by Eryq. All rights reserved. This program is free software; you can redistribute it and/or modify it under the same terms as Perl itself. This makes it GPL+ or Artistic > [YES] Spec file in American English. > [YES] Spec file is legible. > > [NO] Spec file uses macros consistently. > - %install section contains > /usr/bin/find %{buildroot} -type f -name .packlist -exec rm -f {} ';' > while few lines above macro %{__rm} is used Fixed > - %{__chmod} -R u+w %{buildroot}/* > might be replaced with > %{_fixperms} %{buildroot}/* Used %{_fixperms} %{buildroot} Changes applied in CVS (1.119-12). Hi Paul, thank you for quick fixing. (In reply to comment #2) > > lib/Convert/BinHex.pm (the actual code) says (near the end): > > Copyright (c) 1997 by Eryq. All rights reserved. This program is free > software; you can redistribute it and/or modify it under the same terms as > Perl itself. > > This makes it GPL+ or Artistic I'm sorry. I didn't notice this. > > Changes applied in CVS (1.119-12). I went through this new version and everything seems OK. The result is: ACCEPT |